Re: [PATCH v5 10/17] target/m68k: Implement TRAPcc

2022-05-31 Thread Richard Henderson
On 5/31/22 11:05, Laurent Vivier wrote: Hmm.  That will completely hide trapcc -- you should have seen the new test case fail (and if not, the test case needs fixing). I ran "make check", thinking the test is run, and saw no failure... and if I run "make check-tcg", I have:   make: Nothing to

Re: [PATCH v5 10/17] target/m68k: Implement TRAPcc

2022-05-31 Thread Laurent Vivier
Le 31/05/2022 à 16:59, Richard Henderson a écrit : On 5/31/22 01:01, Laurent Vivier wrote: Le 27/05/2022 à 18:48, Richard Henderson a écrit : Resolves: https://gitlab.com/qemu-project/qemu/-/issues/754 Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson ---   target/m68k/cpu.h   

Re: [PATCH v5 10/17] target/m68k: Implement TRAPcc

2022-05-31 Thread Richard Henderson
On 5/31/22 01:01, Laurent Vivier wrote: Le 27/05/2022 à 18:48, Richard Henderson a écrit : Resolves: https://gitlab.com/qemu-project/qemu/-/issues/754 Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson ---   target/m68k/cpu.h  |  2 ++   linux-user/m68k/cpu_loop.c |  1 +   tar

Re: [PATCH v5 10/17] target/m68k: Implement TRAPcc

2022-05-31 Thread Laurent Vivier
Le 27/05/2022 à 18:48, Richard Henderson a écrit : Resolves: https://gitlab.com/qemu-project/qemu/-/issues/754 Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- target/m68k/cpu.h | 2 ++ linux-user/m68k/cpu_loop.c | 1 + target/m68k/cpu.c | 1 + target/m

[PATCH v5 10/17] target/m68k: Implement TRAPcc

2022-05-27 Thread Richard Henderson
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/754 Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- target/m68k/cpu.h | 2 ++ linux-user/m68k/cpu_loop.c | 1 + target/m68k/cpu.c | 1 + target/m68k/op_helper.c| 6 + target/m68k/translate.c