Re: [PATCH v5 1/7] scripts/qapi/gen.py: add FOO.trace-events output module

2022-01-26 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Tue, Jan 25, 2022 at 10:56:49PM +0100, Vladimir Sementsov-Ogievskiy wrote: >> @@ -264,6 +272,14 @@ def _genh(self) -> QAPIGenH: >> assert self._current_module is not None >> return self._module[self._current_module][1] >> >> +@property >> +

Re: [PATCH v5 1/7] scripts/qapi/gen.py: add FOO.trace-events output module

2022-01-26 Thread Markus Armbruster
Let's tweak the title to more closely match existing commits: qapi/gen: Add FOO.trace-events output module Vladimir Sementsov-Ogievskiy writes: > We are going to generate trace events for QMP commands. We should > generate both trace_*() function calls and trace-events files listing > event

Re: [PATCH v5 1/7] scripts/qapi/gen.py: add FOO.trace-events output module

2022-01-26 Thread Stefan Hajnoczi
On Tue, Jan 25, 2022 at 10:56:49PM +0100, Vladimir Sementsov-Ogievskiy wrote: > @@ -264,6 +272,14 @@ def _genh(self) -> QAPIGenH: > assert self._current_module is not None > return self._module[self._current_module][1] > > +@property > +def _gent(self) -> QAPIGenTrace:

[PATCH v5 1/7] scripts/qapi/gen.py: add FOO.trace-events output module

2022-01-25 Thread Vladimir Sementsov-Ogievskiy
We are going to generate trace events for QMP commands. We should generate both trace_*() function calls and trace-events files listing events for trace generator. So, add an output module FOO.trace-events for each FOO schema module. Since we're going to add trace events only to command marshalle