Re: [PATCH v5 1/4] linux-aio: use LinuxAioState from the running thread

2023-03-08 Thread Stefan Hajnoczi
On Wed, Mar 08, 2023 at 12:42:11PM +0100, Kevin Wolf wrote: > Am 07.03.2023 um 15:18 hat Stefan Hajnoczi geschrieben: > > On Tue, Mar 07, 2023 at 09:48:51AM +0100, Kevin Wolf wrote: > > > Am 01.03.2023 um 17:16 hat Stefan Hajnoczi geschrieben: > > > > On Fri, Feb 03, 2023 at 08:17:28AM -0500, Emanu

Re: [PATCH v5 1/4] linux-aio: use LinuxAioState from the running thread

2023-03-08 Thread Kevin Wolf
Am 07.03.2023 um 15:18 hat Stefan Hajnoczi geschrieben: > On Tue, Mar 07, 2023 at 09:48:51AM +0100, Kevin Wolf wrote: > > Am 01.03.2023 um 17:16 hat Stefan Hajnoczi geschrieben: > > > On Fri, Feb 03, 2023 at 08:17:28AM -0500, Emanuele Giuseppe Esposito > > > wrote: > > > > Remove usage of aio_cont

Re: [PATCH v5 1/4] linux-aio: use LinuxAioState from the running thread

2023-03-07 Thread Stefan Hajnoczi
On Tue, Mar 07, 2023 at 09:48:51AM +0100, Kevin Wolf wrote: > Am 01.03.2023 um 17:16 hat Stefan Hajnoczi geschrieben: > > On Fri, Feb 03, 2023 at 08:17:28AM -0500, Emanuele Giuseppe Esposito wrote: > > > Remove usage of aio_context_acquire by always submitting asynchronous > > > AIO to the current

Re: [PATCH v5 1/4] linux-aio: use LinuxAioState from the running thread

2023-03-07 Thread Kevin Wolf
Am 07.03.2023 um 11:58 hat Paolo Bonzini geschrieben: > On 3/7/23 09:48, Kevin Wolf wrote: > > You mean we have a device that has a separate iothread, but a request is > > submitted from the main thread? This isn't even allowed today; if a node > > is in an iothread, all I/O must be submitted from

Re: [PATCH v5 1/4] linux-aio: use LinuxAioState from the running thread

2023-03-07 Thread Paolo Bonzini
On 3/7/23 09:48, Kevin Wolf wrote: You mean we have a device that has a separate iothread, but a request is submitted from the main thread? This isn't even allowed today; if a node is in an iothread, all I/O must be submitted from that iothread. Do you know any code that does submit I/O from the

Re: [PATCH v5 1/4] linux-aio: use LinuxAioState from the running thread

2023-03-07 Thread Kevin Wolf
Am 01.03.2023 um 17:16 hat Stefan Hajnoczi geschrieben: > On Fri, Feb 03, 2023 at 08:17:28AM -0500, Emanuele Giuseppe Esposito wrote: > > Remove usage of aio_context_acquire by always submitting asynchronous > > AIO to the current thread's LinuxAioState. > > > > In order to prevent mistakes from t

Re: [PATCH v5 1/4] linux-aio: use LinuxAioState from the running thread

2023-03-01 Thread Stefan Hajnoczi
On Fri, Feb 03, 2023 at 08:17:28AM -0500, Emanuele Giuseppe Esposito wrote: > Remove usage of aio_context_acquire by always submitting asynchronous > AIO to the current thread's LinuxAioState. > > In order to prevent mistakes from the caller side, avoid passing LinuxAioState > in laio_io_{plug/unp

[PATCH v5 1/4] linux-aio: use LinuxAioState from the running thread

2023-02-03 Thread Emanuele Giuseppe Esposito
Remove usage of aio_context_acquire by always submitting asynchronous AIO to the current thread's LinuxAioState. In order to prevent mistakes from the caller side, avoid passing LinuxAioState in laio_io_{plug/unplug} and laio_co_submit, and document the functions to make clear that they work in th