Re: [PATCH v5 04/18] gdbstub: DebugClass added to system mode.

2024-03-05 Thread nicolas.e...@lauterbach.com
Hi Alex, I managed to include all of your feedback except for the one on this patch: You shouldn't need empty functions if you are not using them. Moreover you should use the inheritance feature and have something like: static void gdb_debug_class_init(ObjectClass *klass, void *data) { De

Re: [PATCH v5 04/18] gdbstub: DebugClass added to system mode.

2024-02-29 Thread Alex Bennée
Nicolas Eder writes: > This class is used to abstract debug features between different debuggers > --- > debug/common/debug.c | 33 + > debug/common/meson.build | 1 + > debug/gdbstub/system.c | 18 ++ > debug/meson.build| 1 + > in

[PATCH v5 04/18] gdbstub: DebugClass added to system mode.

2023-12-20 Thread Nicolas Eder
This class is used to abstract debug features between different debuggers --- debug/common/debug.c | 33 + debug/common/meson.build | 1 + debug/gdbstub/system.c | 18 ++ debug/meson.build| 1 + include/hw/boards.h | 1 + includ