Re: [PATCH v5 01/18] dump: Replace opaque DumpState pointer with a typed one

2022-08-16 Thread Marc-André Lureau
On Thu, Aug 11, 2022 at 4:13 PM Janosch Frank wrote: > > It's always better to convey the type of a pointer if at all > possible. So let's add the DumpState typedef to typedefs.h and move > the dump note functions from the opaque pointers to DumpState > pointers. > > Signed-off-by: Janosch Frank

Re: [PATCH v5 01/18] dump: Replace opaque DumpState pointer with a typed one

2022-08-11 Thread Daniel Henrique Barboza
On 8/11/22 09:10, Janosch Frank wrote: It's always better to convey the type of a pointer if at all possible. So let's add the DumpState typedef to typedefs.h and move the dump note functions from the opaque pointers to DumpState pointers. Signed-off-by: Janosch Frank CC: Peter Maydell CC:

[PATCH v5 01/18] dump: Replace opaque DumpState pointer with a typed one

2022-08-11 Thread Janosch Frank
It's always better to convey the type of a pointer if at all possible. So let's add the DumpState typedef to typedefs.h and move the dump note functions from the opaque pointers to DumpState pointers. Signed-off-by: Janosch Frank CC: Peter Maydell CC: Cédric Le Goater CC: Daniel Henrique Barboz