Re: [PATCH v5 00/20] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-24 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 4 Sep 2020 at 17:05, Peter Maydell wrote: >> On Fri, 4 Sep 2020 at 16:54, Markus Armbruster wrote: >> > visit_module() lets you see the modules. >> > >> > visit_include() lets you see the includes. The same module can be >> > included multiple times. Having to

Re: [PATCH v5 00/20] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-24 Thread Peter Maydell
On Fri, 4 Sep 2020 at 17:05, Peter Maydell wrote: > On Fri, 4 Sep 2020 at 16:54, Markus Armbruster wrote: > > visit_module() lets you see the modules. > > > > visit_include() lets you see the includes. The same module can be > > included multiple times. Having to filter that out would be annoyi

Re: [PATCH v5 00/20] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-04 Thread Peter Maydell
On Fri, 4 Sep 2020 at 16:54, Markus Armbruster wrote: > Initially, the include directive was just that: include another file's > contents right here. > > Back in 2018, we switched from generating monolithic code to generating > modular code. What does that mean? > > Instead of generating the kitc

Re: [PATCH v5 00/20] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-04 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 4 Sep 2020 at 15:34, Markus Armbruster wrote: >> Peter Maydell writes: >> > I'm not sure whether the scripts/qapi code supports telling >> > a consumer of the parsed info about this -- is it sufficient >> > for QAPISchemaGenRSTVisitor to implement the 'visit_incl

Re: [PATCH v5 00/20] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-04 Thread Peter Maydell
On Fri, 4 Sep 2020 at 15:34, Markus Armbruster wrote: > Peter Maydell writes: > > I'm not sure whether the scripts/qapi code supports telling > > a consumer of the parsed info about this -- is it sufficient > > for QAPISchemaGenRSTVisitor to implement the 'visit_include' > > method, find the path

Re: [PATCH v5 00/20] Convert QAPI doc comments to generate rST instead of texinfo

2020-09-04 Thread Markus Armbruster
Peter Maydell writes: > On Mon, 10 Aug 2020 at 20:50, Peter Maydell wrote: >> This series switches all our QAPI doc comments over from >> texinfo format to rST. It then removes all the texinfo >> machinery, because this was the last user of texinfo. >> >> This is largely just a rebase of patchse

Re: [PATCH v5 00/20] Convert QAPI doc comments to generate rST instead of texinfo

2020-08-27 Thread Peter Maydell
On Mon, 10 Aug 2020 at 20:50, Peter Maydell wrote: > This series switches all our QAPI doc comments over from > texinfo format to rST. It then removes all the texinfo > machinery, because this was the last user of texinfo. > > This is largely just a rebase of patchset v4 to current master. > Ther

[PATCH v5 00/20] Convert QAPI doc comments to generate rST instead of texinfo

2020-08-10 Thread Peter Maydell
This series switches all our QAPI doc comments over from texinfo format to rST. It then removes all the texinfo machinery, because this was the last user of texinfo. This is largely just a rebase of patchset v4 to current master. I've had to add three new patches at the front which fix up newly ad