Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-16 Thread Vladimir Sementsov-Ogievskiy
16.12.2020 15:57, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 03:03:08PM +0300, Vladimir Sementsov-Ogievskiy wrote: 16.12.2020 13:41, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 01:25:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: 16.12.2020 12:49, Daniel P. Berrangé wrote: On We

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-16 Thread Daniel P . Berrangé
On Wed, Dec 16, 2020 at 03:03:08PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 16.12.2020 13:41, Daniel P. Berrangé wrote: > > On Wed, Dec 16, 2020 at 01:25:36PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > 16.12.2020 12:49, Daniel P. Berrangé wrote: > > > > On Wed, Dec 16, 2020 at 11:22:

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-16 Thread Vladimir Sementsov-Ogievskiy
16.12.2020 13:41, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 01:25:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: 16.12.2020 12:49, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 11:22:38AM +0300, Vladimir Sementsov-Ogievskiy wrote: 15.12.2020 13:53, Li Feng wrote: This patch addre

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-16 Thread Daniel P . Berrangé
On Wed, Dec 16, 2020 at 01:25:36PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 16.12.2020 12:49, Daniel P. Berrangé wrote: > > On Wed, Dec 16, 2020 at 11:22:38AM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > 15.12.2020 13:53, Li Feng wrote: > > > > This patch addresses this issue: > > > >

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-16 Thread Vladimir Sementsov-Ogievskiy
16.12.2020 12:49, Daniel P. Berrangé wrote: On Wed, Dec 16, 2020 at 11:22:38AM +0300, Vladimir Sementsov-Ogievskiy wrote: 15.12.2020 13:53, Li Feng wrote: This patch addresses this issue: When accessing a volume on an NFS filesystem without supporting the file lock, tools, like qemu-img, will c

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-16 Thread Daniel P . Berrangé
On Wed, Dec 16, 2020 at 11:22:38AM +0300, Vladimir Sementsov-Ogievskiy wrote: > 15.12.2020 13:53, Li Feng wrote: > > This patch addresses this issue: > > When accessing a volume on an NFS filesystem without supporting the file > > lock, > > tools, like qemu-img, will complain "Failed to lock byte

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-16 Thread Vladimir Sementsov-Ogievskiy
15.12.2020 13:53, Li Feng wrote: This patch addresses this issue: When accessing a volume on an NFS filesystem without supporting the file lock, tools, like qemu-img, will complain "Failed to lock byte 100". In the original code, the qemu_has_ofd_lock will test the lock on the "/dev/null" pseudo

Re: [PATCH v5] file-posix: detect the lock using the real file

2020-12-15 Thread Daniel P . Berrangé
On Tue, Dec 15, 2020 at 06:53:56PM +0800, Li Feng wrote: > This patch addresses this issue: > When accessing a volume on an NFS filesystem without supporting the file lock, > tools, like qemu-img, will complain "Failed to lock byte 100". > > In the original code, the qemu_has_ofd_lock will test th

[PATCH v5] file-posix: detect the lock using the real file

2020-12-15 Thread Li Feng
This patch addresses this issue: When accessing a volume on an NFS filesystem without supporting the file lock, tools, like qemu-img, will complain "Failed to lock byte 100". In the original code, the qemu_has_ofd_lock will test the lock on the "/dev/null" pseudo-file. Actually, the file.locking i