Re: [PATCH v5] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-08 Thread Dorinda Bassey
Hi Unfortunately, you are not calling pw_thread_loop_wait yourself, so > that doesn't help me what this is supposed to do. When signaling > things and expecting a certain state and side-effect from a different > thread or context, it's nice to document it. > > I guess this will break the thread lo

Re: [PATCH v5] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-07 Thread Marc-André Lureau
Hi On Fri, Mar 3, 2023 at 8:06 PM Dorinda Bassey >> What are those thread_loop_signal() for? Maybe leave a comment? > > the explanation of the function is in the reference header file. > Yes, I read the reference documentation before asking: "Signal all threads waiting with pw_thread_loop_wait."

Re: [PATCH v5] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-03 Thread Dorinda Bassey
Thanks for the feedback! your comments have been addressed in the latest patch version. What are those thread_loop_signal() for? Maybe leave a comment? the explanation of the function is in the reference header file. regards, Dorinda. On Wed, Mar 1, 2023 at 12:08 PM Marc-André Lureau < marcand

Re: [PATCH v5] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-01 Thread Marc-André Lureau
Hi Dorinda On Tue, Feb 28, 2023 at 2:01 AM Dorinda Bassey wrote: > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as > both an audio sink and source. This backend is available on most systems > > Add Pipewire entry points for QEMU Pipewire audio backend > Add wrappers for

[PATCH v5] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-27 Thread Dorinda Bassey
This commit adds a new audiodev backend to allow QEMU to use Pipewire as both an audio sink and source. This backend is available on most systems Add Pipewire entry points for QEMU Pipewire audio backend Add wrappers for QEMU Pipewire audio backend in qpw_pcm_ops() qpw_write function returns the c