Re: [PATCH v4 for-5.2 1/2] spapr: Use error_append_hint() in spapr_caps.c

On Tue, Jul 28, 2020 at 11:07:26AM +0200, Greg Kurz wrote: > On Tue, 28 Jul 2020 09:26:08 +0200 > Markus Armbruster wrote: > > > Greg Kurz writes: > > > > > On Mon, 20 Jul 2020 17:24:35 +0200 > > > Markus Armbruster wrote: > > > > > >> Greg Kurz writes: > > >> > > >> > We have a dedicated er

Re: [PATCH v4 for-5.2 1/2] spapr: Use error_append_hint() in spapr_caps.c

On Tue, 28 Jul 2020 09:26:08 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > On Mon, 20 Jul 2020 17:24:35 +0200 > > Markus Armbruster wrote: > > > >> Greg Kurz writes: > >> > >> > We have a dedicated error API for hints. Use it instead of embedding > >> > the hint in the error messa

Re: [PATCH v4 for-5.2 1/2] spapr: Use error_append_hint() in spapr_caps.c

Greg Kurz writes: > On Mon, 20 Jul 2020 17:24:35 +0200 > Markus Armbruster wrote: > >> Greg Kurz writes: >> >> > We have a dedicated error API for hints. Use it instead of embedding >> > the hint in the error message, as recommanded in the "qapi/error.h" >> > header file. >> > >> > Since spapr

Re: [PATCH v4 for-5.2 1/2] spapr: Use error_append_hint() in spapr_caps.c

On Mon, 20 Jul 2020 17:24:35 +0200 Markus Armbruster wrote: > Greg Kurz writes: > > > We have a dedicated error API for hints. Use it instead of embedding > > the hint in the error message, as recommanded in the "qapi/error.h" > > header file. > > > > Since spapr_caps_apply() passes &error_fata

Re: [PATCH v4 for-5.2 1/2] spapr: Use error_append_hint() in spapr_caps.c

Greg Kurz writes: > We have a dedicated error API for hints. Use it instead of embedding > the hint in the error message, as recommanded in the "qapi/error.h" > header file. > > Since spapr_caps_apply() passes &error_fatal, all functions must > also call the ERRP_GUARD() macro for error_append_hi

Re: [PATCH v4 for-5.2 1/2] spapr: Use error_append_hint() in spapr_caps.c

On Thu, Jul 16, 2020 at 07:11:11PM +0200, Greg Kurz wrote: > We have a dedicated error API for hints. Use it instead of embedding > the hint in the error message, as recommanded in the "qapi/error.h" > header file. > > Since spapr_caps_apply() passes &error_fatal, all functions must > also call th

[PATCH v4 for-5.2 1/2] spapr: Use error_append_hint() in spapr_caps.c

We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recommanded in the "qapi/error.h" header file. Since spapr_caps_apply() passes &error_fatal, all functions must also call the ERRP_GUARD() macro for error_append_hint() to be functional. While h