Re: [PATCH v4 8/9] common-user: Adjust system call return on FreeBSD

2021-11-17 Thread Philippe Mathieu-Daudé
On 11/17/21 09:32, Richard Henderson wrote: > On 11/17/21 9:23 AM, Philippe Mathieu-Daudé wrote: >> On 11/16/21 12:02, Richard Henderson wrote: >>> From: Warner Losh >>> >>> FreeBSD system calls return positive errno.  On the 4 hosts for >>> which we have support, error is indicated by the C bit s

Re: [PATCH v4 8/9] common-user: Adjust system call return on FreeBSD

2021-11-17 Thread Richard Henderson
On 11/17/21 9:23 AM, Philippe Mathieu-Daudé wrote: On 11/16/21 12:02, Richard Henderson wrote: From: Warner Losh FreeBSD system calls return positive errno. On the 4 hosts for which we have support, error is indicated by the C bit set or clear. Signed-off-by: Warner Losh [rth: Rebase on new

Re: [PATCH v4 8/9] common-user: Adjust system call return on FreeBSD

2021-11-17 Thread Philippe Mathieu-Daudé
On 11/16/21 12:02, Richard Henderson wrote: > From: Warner Losh > > FreeBSD system calls return positive errno. On the 4 hosts for > which we have support, error is indicated by the C bit set or clear. > > Signed-off-by: Warner Losh > [rth: Rebase on new safe_syscall_base api; add #error check

Re: [PATCH v4 8/9] common-user: Adjust system call return on FreeBSD

2021-11-16 Thread Richard Henderson
On 11/16/21 9:58 PM, Warner Losh wrote: +#elif defined(__FreeBSD__) +       /* FreeBSD kernel returns positive errno and C bit set. */ +       jcs     1f I needed to change this to 'jc' and that's all google found for Intel. Yep, that's me jumping between too many arches in one da

Re: [PATCH v4 8/9] common-user: Adjust system call return on FreeBSD

2021-11-16 Thread Warner Losh
On Tue, Nov 16, 2021 at 4:03 AM Richard Henderson < richard.hender...@linaro.org> wrote: > From: Warner Losh > > FreeBSD system calls return positive errno. On the 4 hosts for > which we have support, error is indicated by the C bit set or clear. > > Signed-off-by: Warner Losh > [rth: Rebase on

[PATCH v4 8/9] common-user: Adjust system call return on FreeBSD

2021-11-16 Thread Richard Henderson
From: Warner Losh FreeBSD system calls return positive errno. On the 4 hosts for which we have support, error is indicated by the C bit set or clear. Signed-off-by: Warner Losh [rth: Rebase on new safe_syscall_base api; add #error check.] Signed-off-by: Richard Henderson --- common-user/host