Re: [PATCH v4 4/9] blockdev: Promote several bitmap functions to non-static

2020-05-14 Thread Eric Blake
On 5/14/20 6:45 AM, Vladimir Sementsov-Ogievskiy wrote: 13.05.2020 04:16, Eric Blake wrote: -    HBitmap **backup, Error **errp) +BdrvDirtyBitmap *block_dirty_bitmap_merge(const char *node, const char *target, + BlockDirtyBitmapMergeSourceList *bitm

Re: [PATCH v4 4/9] blockdev: Promote several bitmap functions to non-static

2020-05-14 Thread Vladimir Sementsov-Ogievskiy
13.05.2020 04:16, Eric Blake wrote: -HBitmap **backup, Error **errp) +BdrvDirtyBitmap *block_dirty_bitmap_merge(const char *node, const char *target, + BlockDirtyBitmapMergeSourceList *bitmaps, + HBitmap **

Re: [PATCH v4 4/9] blockdev: Promote several bitmap functions to non-static

2020-05-13 Thread Vladimir Sementsov-Ogievskiy
13.05.2020 04:16, Eric Blake wrote: The next patch will split blockdev.c, which will require accessing some previously-static functions from more than one .c file. But part of promoting a function to public is picking a naming scheme that does not reek of exposing too many internals (two of the

[PATCH v4 4/9] blockdev: Promote several bitmap functions to non-static

2020-05-12 Thread Eric Blake
The next patch will split blockdev.c, which will require accessing some previously-static functions from more than one .c file. But part of promoting a function to public is picking a naming scheme that does not reek of exposing too many internals (two of the three functions were named starting wi