Re: [PATCH v4 4/7] block: Support detached LUKS header creation using blockdev-create

Daniel P. Berrangé writes: [...] > TL;DR: the @detached-header field needs to go, as that's supposed to > be internal only. The mgmt app should only care about 'header' in the > BlockdevCreateOptionsLUKS struct. > > FYI, this whole series is already merged last week. So this will need > a fixup.

Re: [PATCH v4 4/7] block: Support detached LUKS header creation using blockdev-create

On Mon, Feb 19, 2024 at 02:57:13PM +, Daniel P. Berrangé wrote: > On Mon, Feb 19, 2024 at 03:49:30PM +0100, Markus Armbruster wrote: > > One more thing... > > > > Markus Armbruster writes: > > > > > yong.hu...@smartx.com writes: > > > > > >> From: Hyman Huang > > >> > > >> Firstly, enable t

Re: [PATCH v4 4/7] block: Support detached LUKS header creation using blockdev-create

On Mon, Feb 19, 2024 at 03:49:30PM +0100, Markus Armbruster wrote: > One more thing... > > Markus Armbruster writes: > > > yong.hu...@smartx.com writes: > > > >> From: Hyman Huang > >> > >> Firstly, enable the ability to choose the block device containing > >> a detachable LUKS header by adding

Re: [PATCH v4 4/7] block: Support detached LUKS header creation using blockdev-create

One more thing... Markus Armbruster writes: > yong.hu...@smartx.com writes: > >> From: Hyman Huang >> >> Firstly, enable the ability to choose the block device containing >> a detachable LUKS header by adding the 'header' parameter to >> BlockdevCreateOptionsLUKS. >> >> Secondly, when formattin

Re: [PATCH v4 4/7] block: Support detached LUKS header creation using blockdev-create

yong.hu...@smartx.com writes: > From: Hyman Huang > > Firstly, enable the ability to choose the block device containing > a detachable LUKS header by adding the 'header' parameter to > BlockdevCreateOptionsLUKS. > > Secondly, when formatting the LUKS volume with a detachable header, > truncate th

Re: [PATCH v4 4/7] block: Support detached LUKS header creation using blockdev-create

On Tue, Jan 30, 2024 at 01:37:22PM +0800, yong.hu...@smartx.com wrote: > From: Hyman Huang > > Firstly, enable the ability to choose the block device containing > a detachable LUKS header by adding the 'header' parameter to > BlockdevCreateOptionsLUKS. > > Secondly, when formatting the LUKS volu

[PATCH v4 4/7] block: Support detached LUKS header creation using blockdev-create

From: Hyman Huang Firstly, enable the ability to choose the block device containing a detachable LUKS header by adding the 'header' parameter to BlockdevCreateOptionsLUKS. Secondly, when formatting the LUKS volume with a detachable header, truncate the payload volume to length without a header s