Re: [PATCH v4 4/4] virtio: Convert feature properties to OnOffAuto

2025-01-10 Thread Akihiko Odaki
On 2025/01/10 20:23, Daniel P. Berrangé wrote: On Wed, Jan 08, 2025 at 03:17:53PM +0900, Akihiko Odaki wrote: Some features are not always available with vhost. Legacy features are not available with vp_vdpa in particular. virtio devices used to disable them when not available even if the corres

Re: [PATCH v4 4/4] virtio: Convert feature properties to OnOffAuto

2025-01-10 Thread Daniel P . Berrangé
On Wed, Jan 08, 2025 at 03:17:53PM +0900, Akihiko Odaki wrote: > Some features are not always available with vhost. Legacy features are > not available with vp_vdpa in particular. virtio devices used to disable > them when not available even if the corresponding properties were > explicitly set to

Re: [PATCH v4 4/4] virtio: Convert feature properties to OnOffAuto

2025-01-09 Thread Philippe Mathieu-Daudé
On 9/1/25 12:08, Akihiko Odaki wrote: On 2025/01/09 19:56, Philippe Mathieu-Daudé wrote: On 8/1/25 07:17, Akihiko Odaki wrote: Some features are not always available with vhost. Legacy features are not available with vp_vdpa in particular. virtio devices used to disable them when not available

Re: [PATCH v4 4/4] virtio: Convert feature properties to OnOffAuto

2025-01-09 Thread Akihiko Odaki
On 2025/01/09 19:56, Philippe Mathieu-Daudé wrote: On 8/1/25 07:17, Akihiko Odaki wrote: Some features are not always available with vhost. Legacy features are not available with vp_vdpa in particular. virtio devices used to disable them when not available even if the corresponding properties we

Re: [PATCH v4 4/4] virtio: Convert feature properties to OnOffAuto

2025-01-09 Thread Philippe Mathieu-Daudé
On 8/1/25 07:17, Akihiko Odaki wrote: Some features are not always available with vhost. Legacy features are not available with vp_vdpa in particular. virtio devices used to disable them when not available even if the corresponding properties were explicitly set to "on". QEMU already has OnOffAu

Re: [PATCH v4 4/4] virtio: Convert feature properties to OnOffAuto

2025-01-09 Thread Lei Yang
I tested this series of patches v4 with virtio-net regression tests, everything works fine. And the qemu core dump issues that hit it on v3 have gone. Tested-by: Lei Yang On Wed, Jan 8, 2025 at 2:18 PM Akihiko Odaki wrote: > > Some features are not always available with vhost. Legacy features a

[PATCH v4 4/4] virtio: Convert feature properties to OnOffAuto

2025-01-07 Thread Akihiko Odaki
Some features are not always available with vhost. Legacy features are not available with vp_vdpa in particular. virtio devices used to disable them when not available even if the corresponding properties were explicitly set to "on". QEMU already has OnOffAuto type, which includes the "auto" value