Re: [PATCH v4 36/36] linux-user: Remove pgb_dynamic alignment assertion

2024-02-14 Thread Richard Henderson
On 2/14/24 21:07, Philippe Mathieu-Daudé wrote: On 15/2/24 07:20, Richard Henderson wrote: The assertion was never correct, because the alignment is a composite of the image alignment and SHMLBA.  Even if the alignment didn't match the image an assertion would not be correct -- more appropriate

Re: [PATCH v4 36/36] linux-user: Remove pgb_dynamic alignment assertion

2024-02-14 Thread Philippe Mathieu-Daudé
On 15/2/24 07:20, Richard Henderson wrote: The assertion was never correct, because the alignment is a composite of the image alignment and SHMLBA. Even if the alignment didn't match the image an assertion would not be correct -- more appropriate would be an error message about an ill formed ima

[PATCH v4 36/36] linux-user: Remove pgb_dynamic alignment assertion

2024-02-14 Thread Richard Henderson
The assertion was never correct, because the alignment is a composite of the image alignment and SHMLBA. Even if the alignment didn't match the image an assertion would not be correct -- more appropriate would be an error message about an ill formed image. But the image cannot be held to SHMLBA u