Re: [PATCH v4 30/46] qapi/gen.py: Fix edge-case of _is_user_module

2020-09-30 Thread Eduardo Habkost
On Wed, Sep 30, 2020 at 12:31:34AM -0400, John Snow wrote: > The edge case is that if the name is '', this expression returns a > string instead of a bool, which violates our declared type. > > Signed-off-by: John Snow > Reviewed-by: Cleber Rosa Reviewed-by: Eduardo Habkost -- Eduardo

[PATCH v4 30/46] qapi/gen.py: Fix edge-case of _is_user_module

2020-09-29 Thread John Snow
The edge case is that if the name is '', this expression returns a string instead of a bool, which violates our declared type. Signed-off-by: John Snow Reviewed-by: Cleber Rosa --- scripts/qapi/gen.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi/gen.py b/scri