Re: [PATCH v4 20/28] net: Strip virtio-net header when dumping

2023-01-30 Thread Akihiko Odaki
On 2023/01/31 0:47, Michael S. Tsirkin wrote: On Tue, Jan 31, 2023 at 12:36:38AM +0900, Akihiko Odaki wrote: On 2023/01/31 0:12, Michael S. Tsirkin wrote: On Mon, Jan 30, 2023 at 10:47:07PM +0900, Akihiko Odaki wrote: filter-dump specifiees Ethernet as PCAP LinkType, which does not expect virt

Re: [PATCH v4 20/28] net: Strip virtio-net header when dumping

2023-01-30 Thread Michael S. Tsirkin
On Tue, Jan 31, 2023 at 12:36:38AM +0900, Akihiko Odaki wrote: > On 2023/01/31 0:12, Michael S. Tsirkin wrote: > > On Mon, Jan 30, 2023 at 10:47:07PM +0900, Akihiko Odaki wrote: > > > filter-dump specifiees Ethernet as PCAP LinkType, which does not expect > > > virtio-net header. Having virtio-net

Re: [PATCH v4 20/28] net: Strip virtio-net header when dumping

2023-01-30 Thread Akihiko Odaki
On 2023/01/31 0:12, Michael S. Tsirkin wrote: On Mon, Jan 30, 2023 at 10:47:07PM +0900, Akihiko Odaki wrote: filter-dump specifiees Ethernet as PCAP LinkType, which does not expect virtio-net header. Having virtio-net header in such PCAP file breaks PCAP unconsumable. Unfortunately currently the

Re: [PATCH v4 20/28] net: Strip virtio-net header when dumping

2023-01-30 Thread Michael S. Tsirkin
On Mon, Jan 30, 2023 at 10:47:07PM +0900, Akihiko Odaki wrote: > filter-dump specifiees Ethernet as PCAP LinkType, which does not expect > virtio-net header. Having virtio-net header in such PCAP file breaks > PCAP unconsumable. Unfortunately currently there is no LinkType for > virtio-net so for n

[PATCH v4 20/28] net: Strip virtio-net header when dumping

2023-01-30 Thread Akihiko Odaki
filter-dump specifiees Ethernet as PCAP LinkType, which does not expect virtio-net header. Having virtio-net header in such PCAP file breaks PCAP unconsumable. Unfortunately currently there is no LinkType for virtio-net so for now strip virtio-net header to convert the output to Ethernet. Signed-o