Re: [PATCH v4 19/43] accel/tcg: Support split-wx for darwin/iOS with vm_remap

2021-01-05 Thread Richard Henderson
On 1/4/21 8:02 PM, Joelle van Dyne wrote: > Guarding MAP_JIT with > > if (!splitwx) { > flags |= MAP_JIT; > } > > is better because MAP_JIT tells the kernel that we want a RWX mapping > which is not the case. On iOS, special entitlements are needed for > MAP_JIT. Thanks, fixed. r~

Re: [PATCH v4 19/43] accel/tcg: Support split-wx for darwin/iOS with vm_remap

2021-01-04 Thread Joelle van Dyne
Guarding MAP_JIT with if (!splitwx) { flags |= MAP_JIT; } is better because MAP_JIT tells the kernel that we want a RWX mapping which is not the case. On iOS, special entitlements are needed for MAP_JIT. -j On Mon, Dec 14, 2020 at 6:03 AM Richard Henderson wrote: > > Cribbed from code post

[PATCH v4 19/43] accel/tcg: Support split-wx for darwin/iOS with vm_remap

2020-12-14 Thread Richard Henderson
Cribbed from code posted by Joelle van Dyne , and rearranged to a cleaner structure. Reviewed-by: Joelle van Dyne Signed-off-by: Richard Henderson --- accel/tcg/translate-all.c | 65 +++ 1 file changed, 65 insertions(+) diff --git a/accel/tcg/translate-all.c