Re: [PATCH v4 19/28] pc-bios/s390-ccw: Refactor zipl_load_segment function

2025-07-15 Thread Collin Walling
[...] >>> @@ -662,6 +661,9 @@ static int zipl_load_segment(ComponentEntry *entry) >>> */ >>> break; >>> } >>> + >>> +comp_len += bprs->size * (bprs[i].blockct + 1); >>> + >> >> I'm confused by the arithmetic here. Why is size multiplied

Re: [PATCH v4 19/28] pc-bios/s390-ccw: Refactor zipl_load_segment function

2025-07-15 Thread Zhuoying Cai
On 7/14/25 6:10 PM, Collin Walling wrote: > On 7/11/25 5:10 PM, Zhuoying Cai wrote: >> Make the address variable a parameter of zipl_load_segment and return >> segment length. > > There's mixed use of the term "comp_len" and "segment length". Since > the context here is "zipl_load_segment", perha

Re: [PATCH v4 19/28] pc-bios/s390-ccw: Refactor zipl_load_segment function

2025-07-14 Thread Collin Walling
On 7/11/25 5:10 PM, Zhuoying Cai wrote: > Make the address variable a parameter of zipl_load_segment and return > segment length. There's mixed use of the term "comp_len" and "segment length". Since the context here is "zipl_load_segment", perhaps the variable should be "seg_len"? > > Modify th

[PATCH v4 19/28] pc-bios/s390-ccw: Refactor zipl_load_segment function

2025-07-11 Thread Zhuoying Cai
Make the address variable a parameter of zipl_load_segment and return segment length. Modify this function for reuse in the next patch, which allows loading segment or signature data to the destination memory address. Add a comp_len variable to store the length of a segment and return this variab