Re: [PATCH v4 16/19] qapi/expr.py: Add docstrings

2021-04-21 Thread John Snow
On 4/21/21 9:58 AM, Markus Armbruster wrote: John Snow writes: [...] I've made a re-spin. Let's try something new, if you don't mind: I've pushed a "almost v5" copy onto my gitlab, where edits made against this patch are in their own commit so that all of the pending edits I've made are easil

Re: [PATCH v4 16/19] qapi/expr.py: Add docstrings

2021-04-21 Thread Markus Armbruster
John Snow writes: [...] > I've made a re-spin. Let's try something new, if you don't mind: > > I've pushed a "almost v5" copy onto my gitlab, where edits made against > this patch are in their own commit so that all of the pending edits I've > made are easily visible. > > Here's the "merge requ

Re: [PATCH v4 16/19] qapi/expr.py: Add docstrings

2021-04-20 Thread John Snow
On 4/17/21 9:18 AM, Markus Armbruster wrote: John Snow writes: On 4/14/21 11:04 AM, Markus Armbruster wrote: John Snow writes: Thanks for taking this on. I realize it's a slog. (Update: much later: AUUUGH WHY DID I DECIDE TO WRITE DOCS. MY HUBRIS) LOL! Signed-off-by: John Snow -

Re: [PATCH v4 16/19] qapi/expr.py: Add docstrings

2021-04-17 Thread Markus Armbruster
John Snow writes: > On 4/14/21 11:04 AM, Markus Armbruster wrote: >> John Snow writes: >> > > Thanks for taking this on. I realize it's a slog. > > (Update: much later: AUUUGH WHY DID I DECIDE TO WRITE DOCS. MY HUBRIS) LOL! >>> Signed-off-by: John Snow >>> --- >>> scripts/qapi/expr.py

Re: [PATCH v4 16/19] qapi/expr.py: Add docstrings

2021-04-16 Thread John Snow
On 4/14/21 11:04 AM, Markus Armbruster wrote: John Snow writes: Thanks for taking this on. I realize it's a slog. (Update: much later: AUUUGH WHY DID I DECIDE TO WRITE DOCS. MY HUBRIS) Signed-off-by: John Snow --- scripts/qapi/expr.py | 213 ++

Re: [PATCH v4 16/19] qapi/expr.py: Add docstrings

2021-04-14 Thread Markus Armbruster
John Snow writes: > Signed-off-by: John Snow > --- > scripts/qapi/expr.py | 213 ++- > 1 file changed, 208 insertions(+), 5 deletions(-) > > diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py > index 1869ddf815..adc5b903bc 100644 > --- a/scripts/qap

[PATCH v4 16/19] qapi/expr.py: Add docstrings

2021-03-24 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/expr.py | 213 ++- 1 file changed, 208 insertions(+), 5 deletions(-) diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index 1869ddf815..adc5b903bc 100644 --- a/scripts/qapi/expr.py +++ b/scripts/qapi/expr.p