Re: [PATCH v4 13/19] qapi/expr.py: Consolidate check_if_str calls in check_if

2021-03-25 Thread John Snow
On 3/25/21 11:15 AM, Markus Armbruster wrote: John Snow writes: This is a small rewrite to address some minor style nits. Don't compare against the empty list to check for the empty condition, and move the normalization forward to unify the check on the now-normalized structure. With the che

Re: [PATCH v4 13/19] qapi/expr.py: Consolidate check_if_str calls in check_if

2021-03-25 Thread Markus Armbruster
John Snow writes: > This is a small rewrite to address some minor style nits. > > Don't compare against the empty list to check for the empty condition, and > move the normalization forward to unify the check on the now-normalized > structure. > > With the check unified, the local nested function

[PATCH v4 13/19] qapi/expr.py: Consolidate check_if_str calls in check_if

2021-03-24 Thread John Snow
This is a small rewrite to address some minor style nits. Don't compare against the empty list to check for the empty condition, and move the normalization forward to unify the check on the now-normalized structure. With the check unified, the local nested function isn't needed anymore and can be