Re: [PATCH v4 11/25] migration: Add Error** argument to .save_setup() handler

2024-03-08 Thread Peter Xu
On Fri, Mar 08, 2024 at 03:11:04PM +0800, Peter Xu wrote: > On Thu, Mar 07, 2024 at 02:39:31PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > > I would be glad to have most of this series merged in QEMU 9.0. So, > > > unless there is something major, I will keep that for followups. > > Unfortunate

Re: [PATCH v4 11/25] migration: Add Error** argument to .save_setup() handler

2024-03-07 Thread Peter Xu
On Thu, Mar 07, 2024 at 02:39:31PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > I would be glad to have most of this series merged in QEMU 9.0. So, > > unless there is something major, I will keep that for followups. Unfortunately I found this series won't apply to master.. starting from "migrat

Re: [PATCH v4 11/25] migration: Add Error** argument to .save_setup() handler

2024-03-07 Thread Vladimir Sementsov-Ogievskiy
On 07.03.24 13:31, Cédric Le Goater wrote: On 3/7/24 10:53, Vladimir Sementsov-Ogievskiy wrote: On 06.03.24 16:34, Cédric Le Goater wrote: The purpose is to record a potential error in the migration stream if qemu_savevm_state_setup() fails. Most of the current .save_setup() handlers can be mod

Re: [PATCH v4 11/25] migration: Add Error** argument to .save_setup() handler

2024-03-07 Thread Cédric Le Goater
On 3/7/24 10:53, Vladimir Sementsov-Ogievskiy wrote: On 06.03.24 16:34, Cédric Le Goater wrote: The purpose is to record a potential error in the migration stream if qemu_savevm_state_setup() fails. Most of the current .save_setup() handlers can be modified to use the Error argument instead of m

Re: [PATCH v4 11/25] migration: Add Error** argument to .save_setup() handler

2024-03-07 Thread Vladimir Sementsov-Ogievskiy
On 06.03.24 16:34, Cédric Le Goater wrote: The purpose is to record a potential error in the migration stream if qemu_savevm_state_setup() fails. Most of the current .save_setup() handlers can be modified to use the Error argument instead of managing their own and calling locally error_report().

[PATCH v4 11/25] migration: Add Error** argument to .save_setup() handler

2024-03-06 Thread Cédric Le Goater
The purpose is to record a potential error in the migration stream if qemu_savevm_state_setup() fails. Most of the current .save_setup() handlers can be modified to use the Error argument instead of managing their own and calling locally error_report(). Cc: Nicholas Piggin Cc: Harsh Prateek Bora