Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations

2021-02-10 Thread John Snow
On 2/9/21 4:06 AM, Markus Armbruster wrote: John Snow writes: On 2/5/21 8:42 AM, Markus Armbruster wrote: John Snow writes: https://www.python.org/dev/peps/pep-0484/#type-aliases Note that we recommend capitalizing alias names, since they represent user-defined types, which (lik

Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations

2021-02-09 Thread Markus Armbruster
John Snow writes: > On 2/5/21 8:42 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 2/3/21 10:15 AM, Markus Armbruster wrote: John Snow writes: > Signed-off-by: John Snow > --- >scripts/qapi/introspect.py | 115 ++--- >

Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations

2021-02-08 Thread John Snow
On 2/8/21 4:39 PM, John Snow wrote: I'm once again terminally confused about when to use _lower_case and when to use CamelCase for such variables. That's my fault for not using them consistently. Generally: TitleCase: Classes, Real Type Names :tm: lowercase: instance names (and certain buil

Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations

2021-02-08 Thread John Snow
On 2/5/21 8:42 AM, Markus Armbruster wrote: John Snow writes: On 2/3/21 10:15 AM, Markus Armbruster wrote: John Snow writes: Signed-off-by: John Snow --- scripts/qapi/introspect.py | 115 ++--- scripts/qapi/mypy.ini | 5 -- scripts/qapi/schema

Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations

2021-02-05 Thread Markus Armbruster
John Snow writes: > On 2/3/21 10:15 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> Signed-off-by: John Snow >>> --- >>> scripts/qapi/introspect.py | 115 ++--- >>> scripts/qapi/mypy.ini | 5 -- >>> scripts/qapi/schema.py | 2 +- >>> 3

Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations

2021-02-03 Thread John Snow
On 2/3/21 10:15 AM, Markus Armbruster wrote: John Snow writes: Signed-off-by: John Snow --- scripts/qapi/introspect.py | 115 ++--- scripts/qapi/mypy.ini | 5 -- scripts/qapi/schema.py | 2 +- 3 files changed, 82 insertions(+), 40 deletions(-)

Re: [PATCH v4 11/14] qapi/introspect.py: add type hint annotations

2021-02-03 Thread Markus Armbruster
John Snow writes: > Signed-off-by: John Snow > --- > scripts/qapi/introspect.py | 115 ++--- > scripts/qapi/mypy.ini | 5 -- > scripts/qapi/schema.py | 2 +- > 3 files changed, 82 insertions(+), 40 deletions(-) > > diff --git a/scripts/qapi/introspec

[PATCH v4 11/14] qapi/introspect.py: add type hint annotations

2021-02-02 Thread John Snow
Signed-off-by: John Snow --- scripts/qapi/introspect.py | 115 ++--- scripts/qapi/mypy.ini | 5 -- scripts/qapi/schema.py | 2 +- 3 files changed, 82 insertions(+), 40 deletions(-) diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py i