Re: [PATCH v4 1/5] char: add goldfish-tty

2021-03-07 Thread Richard Henderson
On 3/7/21 11:57 AM, Laurent Vivier wrote: Le 07/03/2021 à 20:24, Philippe Mathieu-Daudé a écrit : The spec says this register is only available on 64-bit targets. Should we restrict this "#if TARGET_LONG_SIZE == 8"? else log_mask(GUEST_ERROR)... This seems overkill to me but that would respect

Re: [PATCH v4 1/5] char: add goldfish-tty

2021-03-07 Thread Laurent Vivier
Le 07/03/2021 à 20:24, Philippe Mathieu-Daudé a écrit : > On 3/7/21 5:48 PM, Laurent Vivier wrote: >> Implement the goldfish tty device as defined in >> >> https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT >> >> and based on the kernel driver code:

Re: [PATCH v4 1/5] char: add goldfish-tty

2021-03-07 Thread Philippe Mathieu-Daudé
On 3/7/21 5:48 PM, Laurent Vivier wrote: > Implement the goldfish tty device as defined in > > https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT > > and based on the kernel driver code: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds

[PATCH v4 1/5] char: add goldfish-tty

2021-03-07 Thread Laurent Vivier
Implement the goldfish tty device as defined in https://android.googlesource.com/platform/external/qemu/+/master/docs/GOLDFISH-VIRTUAL-HARDWARE.TXT and based on the kernel driver code: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/goldfish.c Signed-off-by: