Re: [PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands

2020-03-06 Thread Kevin Wolf
Am 06.03.2020 um 13:38 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 06.03.2020 um 08:25 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > Am 05.03.2020 um 16:30 hat Markus Armbruster geschrieben: > >> >> Kevin Wolf writes: > >> >> > >> >> > Am 22.01.20

Re: [PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands

2020-03-06 Thread Markus Armbruster
Kevin Wolf writes: > Am 06.03.2020 um 08:25 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 05.03.2020 um 16:30 hat Markus Armbruster geschrieben: >> >> Kevin Wolf writes: >> >> >> >> > Am 22.01.2020 um 07:32 hat Markus Armbruster geschrieben: >> >> >> Kevin Wolf writes:

Re: [PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands

2020-03-06 Thread Kevin Wolf
Am 06.03.2020 um 08:25 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 05.03.2020 um 16:30 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > Am 22.01.2020 um 07:32 hat Markus Armbruster geschrieben: > >> >> Kevin Wolf writes: > >> >> > >> >> > This patch

Re: [PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands

2020-03-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 05.03.2020 um 16:30 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 22.01.2020 um 07:32 hat Markus Armbruster geschrieben: >> >> Kevin Wolf writes: >> >> >> >> > This patch adds a new 'coroutine' flag to QMP command definitions that >> >> > tells th

Re: [PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands

2020-03-05 Thread Kevin Wolf
Am 05.03.2020 um 16:30 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 22.01.2020 um 07:32 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > This patch adds a new 'coroutine' flag to QMP command definitions that > >> > tells the QMP dispatcher that the comm

Re: [PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands

2020-03-05 Thread Markus Armbruster
Kevin Wolf writes: > Am 22.01.2020 um 07:32 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > This patch adds a new 'coroutine' flag to QMP command definitions that >> > tells the QMP dispatcher that the command handler is safe to be run in a >> > coroutine. >> >> I'm afraid I m

Re: [PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands

2020-02-16 Thread Markus Armbruster
Kevin Wolf writes: > This patch adds a new 'coroutine' flag to QMP command definitions that > tells the QMP dispatcher that the command handler is safe to be run in a > coroutine. > > The documentation of the new flag pretends that this flag is already > used as intended, which it isn't yet after

Re: [PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-22 Thread Kevin Wolf
Am 22.01.2020 um 13:15 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 22.01.2020 um 07:32 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > This patch adds a new 'coroutine' flag to QMP command definitions that > >> > tells the QMP dispatcher that the comm

Re: [PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-22 Thread Markus Armbruster
Kevin Wolf writes: > Am 22.01.2020 um 07:32 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > This patch adds a new 'coroutine' flag to QMP command definitions that >> > tells the QMP dispatcher that the command handler is safe to be run in a >> > coroutine. >> >> I'm afraid I m

Re: [PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-22 Thread Kevin Wolf
Am 22.01.2020 um 07:32 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > This patch adds a new 'coroutine' flag to QMP command definitions that > > tells the QMP dispatcher that the command handler is safe to be run in a > > coroutine. > > I'm afraid I missed this question in my revi

Re: [PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-21 Thread Markus Armbruster
Kevin Wolf writes: > This patch adds a new 'coroutine' flag to QMP command definitions that > tells the QMP dispatcher that the command handler is safe to be run in a > coroutine. I'm afraid I missed this question in my review of v3: when is a handler *not* safe to be run in a coroutine? > The

[PATCH v4 1/4] qapi: Add a 'coroutine' flag for commands

2020-01-21 Thread Kevin Wolf
This patch adds a new 'coroutine' flag to QMP command definitions that tells the QMP dispatcher that the command handler is safe to be run in a coroutine. The documentation of the new flag pretends that this flag is already used as intended, which it isn't yet after this patch. We'll implement thi