Re: [PATCH v4 1/4] KVM: Dynamic sized kvm memslots array

2024-10-21 Thread Peter Xu
On Mon, Oct 21, 2024 at 10:05:23PM +0300, Michael Tokarev wrote: > 21.10.2024 17:37, Peter Xu wrote: > > Michael, > > > > On Fri, Oct 18, 2024 at 06:38:53PM +0300, Michael Tokarev wrote: > > > Looking at this from qemu-stable PoV, I'm not 100% sure this change is > > > good > > > for stable-7.2 s

Re: [PATCH v4 1/4] KVM: Dynamic sized kvm memslots array

2024-10-21 Thread Michael Tokarev
21.10.2024 17:37, Peter Xu wrote: Michael, On Fri, Oct 18, 2024 at 06:38:53PM +0300, Michael Tokarev wrote: Looking at this from qemu-stable PoV, I'm not 100% sure this change is good for stable-7.2 series, because 7.2 lacks v8.1.0-1571-g5b23186a95 "kvm: Return number of free memslots" commit,

Re: [PATCH v4 1/4] KVM: Dynamic sized kvm memslots array

2024-10-21 Thread Peter Xu
Michael, On Fri, Oct 18, 2024 at 06:38:53PM +0300, Michael Tokarev wrote: > Looking at this from qemu-stable PoV, I'm not 100% sure this change is good > for stable-7.2 series, because 7.2 lacks v8.1.0-1571-g5b23186a95 > "kvm: Return number of free memslots" commit, which was a preparation for > f

Re: [PATCH v4 1/4] KVM: Dynamic sized kvm memslots array

2024-10-18 Thread Michael Tokarev
17.09.2024 19:38, Peter Xu wrote: Zhiyi reported an infinite loop issue in VFIO use case. The cause of that was a separate discussion, however during that I found a regression of dirty sync slowness when profiling. Each KVMMemoryListerner maintains an array of kvm memslots. Currently it's stat

Re: [PATCH v4 1/4] KVM: Dynamic sized kvm memslots array

2024-09-19 Thread David Hildenbrand
On 17.09.24 18:38, Peter Xu wrote: Zhiyi reported an infinite loop issue in VFIO use case. The cause of that was a separate discussion, however during that I found a regression of dirty sync slowness when profiling. Each KVMMemoryListerner maintains an array of kvm memslots. Currently it's sta

Re: [PATCH v4 1/4] KVM: Dynamic sized kvm memslots array

2024-09-17 Thread Fabiano Rosas
Peter Xu writes: > Zhiyi reported an infinite loop issue in VFIO use case. The cause of that > was a separate discussion, however during that I found a regression of > dirty sync slowness when profiling. > > Each KVMMemoryListerner maintains an array of kvm memslots. Currently it's > statically

[PATCH v4 1/4] KVM: Dynamic sized kvm memslots array

2024-09-17 Thread Peter Xu
Zhiyi reported an infinite loop issue in VFIO use case. The cause of that was a separate discussion, however during that I found a regression of dirty sync slowness when profiling. Each KVMMemoryListerner maintains an array of kvm memslots. Currently it's statically allocated to be the max suppo