Re: [PATCH v4 1/3] scripts/qapi/gen.py: add FOO.trace-events output module

2022-01-25 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 25.01.2022 12:07, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> We are going to generate trace events for qmp commands. We should >> >> QMP >> >>> generate both trace_*() function calls and trace-events files listing >>> events

Re: [PATCH v4 1/3] scripts/qapi/gen.py: add FOO.trace-events output module

2022-01-25 Thread Vladimir Sementsov-Ogievskiy
25.01.2022 12:07, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: We are going to generate trace events for qmp commands. We should QMP generate both trace_*() function calls and trace-events files listing events for trace generator. So, add an output module FOO.trace-events

Re: [PATCH v4 1/3] scripts/qapi/gen.py: add FOO.trace-events output module

2022-01-25 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > We are going to generate trace events for qmp commands. We should QMP > generate both trace_*() function calls and trace-events files listing > events for trace generator. > > So, add an output module FOO.trace-events for each FOO schema module. > > Still,

Re: [PATCH v4 1/3] scripts/qapi/gen.py: add FOO.trace-events output module

2022-01-21 Thread John Snow
On Fri, Jan 21, 2022 at 11:22 AM Vladimir Sementsov-Ogievskiy wrote: > > We are going to generate trace events for qmp commands. We should > generate both trace_*() function calls and trace-events files listing > events for trace generator. > > So, add an output module FOO.trace-events for each FO

[PATCH v4 1/3] scripts/qapi/gen.py: add FOO.trace-events output module

2022-01-21 Thread Vladimir Sementsov-Ogievskiy
We are going to generate trace events for qmp commands. We should generate both trace_*() function calls and trace-events files listing events for trace generator. So, add an output module FOO.trace-events for each FOO schema module. Still, we'll need these .trace-events files only for QAPISchema