Re: [PATCH v4 1/3] qga: Refactor guest-exec capture-output to take enum

2023-03-09 Thread Daniel Xu
Hi Daniel, On Thu, Mar 09, 2023 at 09:29:34AM +, Daniel P. Berrangé wrote: > On Wed, Mar 08, 2023 at 03:49:39PM -0700, Daniel Xu wrote: > > Previously capture-output was an optional boolean flag that either > > captured all output or captured none. While this is OK in most cases, it > > lacks

Re: [PATCH v4 1/3] qga: Refactor guest-exec capture-output to take enum

2023-03-09 Thread Daniel P . Berrangé
On Wed, Mar 08, 2023 at 03:49:39PM -0700, Daniel Xu wrote: > Previously capture-output was an optional boolean flag that either > captured all output or captured none. While this is OK in most cases, it > lacks flexibility for more advanced capture cases, such as wanting to > only capture stdout. >

[PATCH v4 1/3] qga: Refactor guest-exec capture-output to take enum

2023-03-08 Thread Daniel Xu
Previously capture-output was an optional boolean flag that either captured all output or captured none. While this is OK in most cases, it lacks flexibility for more advanced capture cases, such as wanting to only capture stdout. This commits refactors guest-exec qapi to take an enum for capture