Tricore default machine (was: [PATCH v4 1/3] hw: Do not initialize MachineClass::is_default to 0)

2020-02-10 Thread Thomas Huth
On 07/02/2020 17.19, Philippe Mathieu-Daudé wrote: > The MachineClass is already zeroed on creation. > > Note: The code setting is_default=0 in hw/i386/pc_piix.c is > different (related to compat options). When adding a > new versioned machine, we want it to be the new default, >

Re: [PATCH v4 1/3] hw: Do not initialize MachineClass::is_default to 0

2020-02-08 Thread David Gibson
On Fri, Feb 07, 2020 at 05:19:46PM +0100, Philippe Mathieu-Daudé wrote: > The MachineClass is already zeroed on creation. > > Note: The code setting is_default=0 in hw/i386/pc_piix.c is > different (related to compat options). When adding a > new versioned machine, we want it to be the

Re: [PATCH v4 1/3] hw: Do not initialize MachineClass::is_default to 0

2020-02-07 Thread Laurent Vivier
Le 07/02/2020 à 17:19, Philippe Mathieu-Daudé a écrit : > The MachineClass is already zeroed on creation. > > Note: The code setting is_default=0 in hw/i386/pc_piix.c is > different (related to compat options). When adding a > new versioned machine, we want it to be the new default, >

[PATCH v4 1/3] hw: Do not initialize MachineClass::is_default to 0

2020-02-07 Thread Philippe Mathieu-Daudé
The MachineClass is already zeroed on creation. Note: The code setting is_default=0 in hw/i386/pc_piix.c is different (related to compat options). When adding a new versioned machine, we want it to be the new default, so we have to mark the previous one as not default. Signed-of