Re: [PATCH v4 1/3] block/rbd: encryption nit fixes

2023-01-12 Thread Ilya Dryomov
On Thu, Jan 12, 2023 at 3:46 PM Daniel P. Berrangé wrote: > > On Thu, Jan 12, 2023 at 03:26:56PM +0100, Ilya Dryomov wrote: > > On Thu, Jan 12, 2023 at 1:35 PM Daniel P. Berrangé > > wrote: > > > > > > On Sun, Nov 20, 2022 at 04:28:34AM -0600, Or Ozeri wrote: > > > > Add const modifier to passph

Re: [PATCH v4 1/3] block/rbd: encryption nit fixes

2023-01-12 Thread Daniel P . Berrangé
On Thu, Jan 12, 2023 at 06:07:58PM +0100, Ilya Dryomov wrote: > On Thu, Jan 12, 2023 at 3:46 PM Daniel P. Berrangé > wrote: > > > > On Thu, Jan 12, 2023 at 03:26:56PM +0100, Ilya Dryomov wrote: > > > On Thu, Jan 12, 2023 at 1:35 PM Daniel P. Berrangé > > > wrote: > > > > > > > > On Sun, Nov 20,

Re: [PATCH v4 1/3] block/rbd: encryption nit fixes

2023-01-12 Thread Daniel P . Berrangé
On Thu, Jan 12, 2023 at 03:26:56PM +0100, Ilya Dryomov wrote: > On Thu, Jan 12, 2023 at 1:35 PM Daniel P. Berrangé > wrote: > > > > On Sun, Nov 20, 2022 at 04:28:34AM -0600, Or Ozeri wrote: > > > Add const modifier to passphrases, > > > and remove redundant stack variable passphrase_len. > > > >

Re: [PATCH v4 1/3] block/rbd: encryption nit fixes

2023-01-12 Thread Ilya Dryomov
On Thu, Jan 12, 2023 at 1:35 PM Daniel P. Berrangé wrote: > > On Sun, Nov 20, 2022 at 04:28:34AM -0600, Or Ozeri wrote: > > Add const modifier to passphrases, > > and remove redundant stack variable passphrase_len. > > > > Signed-off-by: Or Ozeri > > --- > > block/rbd.c | 24 ++--

Re: [PATCH v4 1/3] block/rbd: encryption nit fixes

2023-01-12 Thread Daniel P . Berrangé
On Sun, Nov 20, 2022 at 04:28:34AM -0600, Or Ozeri wrote: > Add const modifier to passphrases, > and remove redundant stack variable passphrase_len. > > Signed-off-by: Or Ozeri > --- > block/rbd.c | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) > > diff --git

[PATCH v4 1/3] block/rbd: encryption nit fixes

2022-11-20 Thread Or Ozeri
Add const modifier to passphrases, and remove redundant stack variable passphrase_len. Signed-off-by: Or Ozeri --- block/rbd.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index f826410f40..e575105e6d 100644 --- a/block/