Re: [PATCH v4 1/2] qemu/atomic: Update coding style to make checkpatch.pl happier

2020-09-23 Thread Carlo Marcelo Arenas Belón
will be also nice to squash the following on top for a complete clean checkpatch version, as the original patch introduces at least 1 issue Carlo --- >8 --- Subject: fixup! [PATCH 1/2] qemu/atomic.h: rename atomic_ to qatomic_ fixes: ERROR: Macros with multiple statements should be enclosed in a

Re: [PATCH v4 1/2] qemu/atomic: Update coding style to make checkpatch.pl happier

2020-09-23 Thread Stefan Hajnoczi
On Wed, Sep 23, 2020 at 05:19:00PM +0200, Philippe Mathieu-Daudé wrote: > To limit the number of checkpatch errors in the next commit, > clean coding style issues first. > > Signed-off-by: Philippe Mathieu-Daudé > --- > False positive: > > ERROR: Use of volatile is usually wrong, please add a c

[PATCH v4 1/2] qemu/atomic: Update coding style to make checkpatch.pl happier

2020-09-23 Thread Philippe Mathieu-Daudé
To limit the number of checkpatch errors in the next commit, clean coding style issues first. Signed-off-by: Philippe Mathieu-Daudé --- False positive: ERROR: Use of volatile is usually wrong, please add a comment #11: FILE: include/qemu/atomic.h:328: +#define atomic_read__nocheck(p) (*(__t