Re: [PATCH v4 05/19] qapi/expr.py: constrain incoming expression types

2021-03-26 Thread John Snow
On 3/26/21 1:40 AM, Markus Armbruster wrote: John Snow writes: On 3/25/21 10:04 AM, Markus Armbruster wrote: John Snow writes: mypy does not know the types of values stored in Dicts that masquerade as objects. Help the type checker out by constraining the type. Signed-off-by: John Snow -

Re: [PATCH v4 05/19] qapi/expr.py: constrain incoming expression types

2021-03-25 Thread Markus Armbruster
John Snow writes: > On 3/25/21 10:04 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> mypy does not know the types of values stored in Dicts that masquerade >>> as objects. Help the type checker out by constraining the type. >>> >>> Signed-off-by: John Snow >>> --- >>> scripts/qapi/e

Re: [PATCH v4 05/19] qapi/expr.py: constrain incoming expression types

2021-03-25 Thread John Snow
On 3/25/21 10:04 AM, Markus Armbruster wrote: John Snow writes: mypy does not know the types of values stored in Dicts that masquerade as objects. Help the type checker out by constraining the type. Signed-off-by: John Snow --- scripts/qapi/expr.py | 26 +++--- 1 file

Re: [PATCH v4 05/19] qapi/expr.py: constrain incoming expression types

2021-03-25 Thread Markus Armbruster
John Snow writes: > mypy does not know the types of values stored in Dicts that masquerade > as objects. Help the type checker out by constraining the type. > > Signed-off-by: John Snow > --- > scripts/qapi/expr.py | 26 +++--- > 1 file changed, 23 insertions(+), 3 deletions

[PATCH v4 05/19] qapi/expr.py: constrain incoming expression types

2021-03-24 Thread John Snow
mypy does not know the types of values stored in Dicts that masquerade as objects. Help the type checker out by constraining the type. Signed-off-by: John Snow --- scripts/qapi/expr.py | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/scripts/qapi/ex