Re: [PATCH v4 04/18] tests/qapi/doc-good.json: Clean up markup

2020-08-06 Thread Peter Maydell
On Thu, 6 Aug 2020 at 15:46, Markus Armbruster wrote: > Remind me, how is messed up doc comment indentation reported in the > brave new Sphinx world? For insufficient indentatation, like this: GEN qapi-gen In file included from /home/petmay01/linaro/qemu-from-laptop/qemu/qapi/qapi-schema.j

Re: [PATCH v4 04/18] tests/qapi/doc-good.json: Clean up markup

2020-08-06 Thread Markus Armbruster
Peter Maydell writes: > On Wed, 5 Aug 2020 at 14:03, Markus Armbruster wrote: >> >> The subject is a bit misleading. The markup doesn't need cleanup. It >> purposefully tests corner cases of the doc comment parser. For some of >> them, the conversion to rST will change the meaning. This comm

Re: [PATCH v4 04/18] tests/qapi/doc-good.json: Clean up markup

2020-08-05 Thread Peter Maydell
On Wed, 5 Aug 2020 at 14:03, Markus Armbruster wrote: > > The subject is a bit misleading. The markup doesn't need cleanup. It > purposefully tests corner cases of the doc comment parser. For some of > them, the conversion to rST will change the meaning. This commit tweaks > the test so it pas

Re: [PATCH v4 04/18] tests/qapi/doc-good.json: Clean up markup

2020-08-05 Thread Markus Armbruster
The subject is a bit misleading. The markup doesn't need cleanup. It purposefully tests corner cases of the doc comment parser. For some of them, the conversion to rST will change the meaning. This commit tweaks the test so it passes before and after the conversion. Makes it a worse test for t

Re: [PATCH v4 04/18] tests/qapi/doc-good.json: Clean up markup

2020-03-10 Thread Richard Henderson
On 3/9/20 8:43 AM, Peter Maydell wrote: > doc-good.json tests some oddities of markup that we don't want to > accept. Make them match the more restrictive rST syntax: > > * in a single list the bullet types must all match > * lists must have leading and following blank lines > * indentation is

[PATCH v4 04/18] tests/qapi/doc-good.json: Clean up markup

2020-03-09 Thread Peter Maydell
doc-good.json tests some oddities of markup that we don't want to accept. Make them match the more restrictive rST syntax: * in a single list the bullet types must all match * lists must have leading and following blank lines * indentation is important * the '|' example syntax is going to go