Re: [PATCH v4 04/17] dump: Rework get_start_block

2022-07-28 Thread Steffen Eiden
On 7/26/22 11:22, Janosch Frank wrote: get_start_block() returns the start address of the first memory block or -1. With the GuestPhysBlock iterator conversion we don't need to set the start address and can therefore remove that code. The only functionality left is the validation of the start

Re: [PATCH v4 04/17] dump: Rework get_start_block

2022-07-27 Thread Janis Schoetterl-Glausch
On 7/26/22 11:22, Janosch Frank wrote: > get_start_block() returns the start address of the first memory block > or -1. > > With the GuestPhysBlock iterator conversion we don't need to set the > start address and can therefore remove that code. The only > functionality left is the validation of th

Re: [PATCH v4 04/17] dump: Rework get_start_block

2022-07-26 Thread Marc-André Lureau
On Tue, Jul 26, 2022 at 1:23 PM Janosch Frank wrote: > > get_start_block() returns the start address of the first memory block > or -1. > > With the GuestPhysBlock iterator conversion we don't need to set the > start address and can therefore remove that code. The only > functionality left is the

[PATCH v4 04/17] dump: Rework get_start_block

2022-07-26 Thread Janosch Frank
get_start_block() returns the start address of the first memory block or -1. With the GuestPhysBlock iterator conversion we don't need to set the start address and can therefore remove that code. The only functionality left is the validation of the start block so it only makes sense to re-name the