Re: [PATCH v4 03/45] error: Document Error API usage rules

2020-07-07 Thread Eric Blake
On 7/7/20 2:23 PM, Markus Armbruster wrote: It helps that you have repeated the same pattern as above. But that means if you change the layout, both groupings should have the same layout. Maybe: Intro for a task: - when the function returns... - when it doesn't Also, are there functions that

Re: [PATCH v4 03/45] error: Document Error API usage rules

2020-07-07 Thread Markus Armbruster
Eric Blake writes: > On 7/7/20 11:05 AM, Markus Armbruster wrote: >> This merely codifies existing practice, with one exception: the rule >> advising against returning void, where existing practice is mixed. >> >> When the Error API was created, we adopted the (unwritten) rule to >> return void w

Re: [PATCH v4 03/45] error: Document Error API usage rules

2020-07-07 Thread Eric Blake
On 7/7/20 11:05 AM, Markus Armbruster wrote: This merely codifies existing practice, with one exception: the rule advising against returning void, where existing practice is mixed. When the Error API was created, we adopted the (unwritten) rule to return void when the function returns no useful

[PATCH v4 03/45] error: Document Error API usage rules

2020-07-07 Thread Markus Armbruster
This merely codifies existing practice, with one exception: the rule advising against returning void, where existing practice is mixed. When the Error API was created, we adopted the (unwritten) rule to return void when the function returns no useful value on success, unlike GError, which recommen