RE: [PATCH v4 02/10] colo: make colo_checkpoint_notify static and provide simpler API

2023-05-04 Thread Zhang, Chen
as > Subject: [PATCH v4 02/10] colo: make colo_checkpoint_notify static and > provide simpler API > > colo_checkpoint_notify() is mostly used in colo.c. Outside we use it once > when x-checkpoint-delay migration parameter is set. So, let's simplify the > external API to only

Re: [PATCH v4 02/10] colo: make colo_checkpoint_notify static and provide simpler API

2023-05-02 Thread Peter Xu
On Fri, Apr 28, 2023 at 10:49:20PM +0300, Vladimir Sementsov-Ogievskiy wrote: > colo_checkpoint_notify() is mostly used in colo.c. Outside we use it > once when x-checkpoint-delay migration parameter is set. So, let's > simplify the external API to only that function - notify COLO that > parameter

Re: [PATCH v4 02/10] colo: make colo_checkpoint_notify static and provide simpler API

2023-05-02 Thread Juan Quintela
Vladimir Sementsov-Ogievskiy wrote: > colo_checkpoint_notify() is mostly used in colo.c. Outside we use it > once when x-checkpoint-delay migration parameter is set. So, let's > simplify the external API to only that function - notify COLO that > parameter was set. This make external API more robu

[PATCH v4 02/10] colo: make colo_checkpoint_notify static and provide simpler API

2023-04-28 Thread Vladimir Sementsov-Ogievskiy
colo_checkpoint_notify() is mostly used in colo.c. Outside we use it once when x-checkpoint-delay migration parameter is set. So, let's simplify the external API to only that function - notify COLO that parameter was set. This make external API more robust and hides implementation details from exte