Re: [PATCH v4 01/31] errp: rename errp to errp_in where it is IN-argument

Vladimir Sementsov-Ogievskiy writes: > 08.10.2019 12:08, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: [...] >>> diff --git a/util/error.c b/util/error.c >>> index d4532ce318..b3ff3832d6 100644 >>> --- a/util/error.c >>> +++ b/util/error.c >>> @@ -271,11 +271,11 @@ void error_

Re: [PATCH v4 01/31] errp: rename errp to errp_in where it is IN-argument

Vladimir Sementsov-Ogievskiy writes: > 08.10.2019 15:05, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 08.10.2019 12:08, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > Error **errp is almost always OUT-argument: it's assumed to be NULL,

Re: [PATCH v4 01/31] errp: rename errp to errp_in where it is IN-argument

08.10.2019 15:05, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> 08.10.2019 12:08, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> Error **errp is almost always OUT-argument: it's assumed to be NULL, or pointer to NULL-initialized pointer, or

Re: [PATCH v4 01/31] errp: rename errp to errp_in where it is IN-argument

08.10.2019 12:08, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> Error **errp is almost always OUT-argument: it's assumed to be NULL, or >> pointer to NULL-initialized pointer, or pointer to error_abort or >> error_fatal, for callee to report error. > > Yes. > >> But very

Re: [PATCH v4 01/31] errp: rename errp to errp_in where it is IN-argument

Vladimir Sementsov-Ogievskiy writes: > 08.10.2019 12:08, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Error **errp is almost always OUT-argument: it's assumed to be NULL, or >>> pointer to NULL-initialized pointer, or pointer to error_abort or >>> error_fatal, for cal

Re: [PATCH v4 01/31] errp: rename errp to errp_in where it is IN-argument

08.10.2019 12:08, Markus Armbruster wrote: > Vladimir Sementsov-Ogievskiy writes: > >> Error **errp is almost always OUT-argument: it's assumed to be NULL, or >> pointer to NULL-initialized pointer, or pointer to error_abort or >> error_fatal, for callee to report error. > > Yes. > >> But very

Re: [PATCH v4 01/31] errp: rename errp to errp_in where it is IN-argument

Vladimir Sementsov-Ogievskiy writes: > Error **errp is almost always OUT-argument: it's assumed to be NULL, or > pointer to NULL-initialized pointer, or pointer to error_abort or > error_fatal, for callee to report error. Yes. > But very few functions instead get Error **errp as IN-argument: >

[PATCH v4 01/31] errp: rename errp to errp_in where it is IN-argument

Error **errp is almost always OUT-argument: it's assumed to be NULL, or pointer to NULL-initialized pointer, or pointer to error_abort or error_fatal, for callee to report error. But very few functions instead get Error **errp as IN-argument: it's assumed to be set, and callee should clean it. In