Re: [PATCH v4 00/23] migration: propagate vTPM errors using Error objects

2025-07-17 Thread Fabiano Rosas
Arun Menon writes: > Hi Fabiano, > > Thanks for the quick review and for catching the make check failure. > My apologies for that oversight, it's definitely an embarrassing miss on my > part. That's ok, you don't do this every day. =) > I see what happened there. I ran make check without sud

Re: [PATCH v4 00/23] migration: propagate vTPM errors using Error objects

2025-07-16 Thread Arun Menon
Hi Fabiano, Thanks for the quick review and for catching the make check failure. My apologies for that oversight, it's definitely an embarrassing miss on my part. I see what happened there. I ran make check without sudo, therefore the postcopy tests were missed ; because it requires userfaul

Re: [PATCH v4 00/23] migration: propagate vTPM errors using Error objects

2025-07-16 Thread Fabiano Rosas
Arun Menon writes: > Hello, > > Currently, when a migration of a VM with an encrypted vTPM > fails on the destination host (e.g., due to a mismatch in secret values), > the error message displayed on the source host is generic and unhelpful. > > For example, a typical error looks like this: > "op

[PATCH v4 00/23] migration: propagate vTPM errors using Error objects

2025-07-16 Thread Arun Menon
Hello, Currently, when a migration of a VM with an encrypted vTPM fails on the destination host (e.g., due to a mismatch in secret values), the error message displayed on the source host is generic and unhelpful. For example, a typical error looks like this: "operation failed: job 'migration out'