Re: [PATCH v4 00/19] Clean up includes

2023-01-19 Thread Michael S. Tsirkin
On Thu, Jan 19, 2023 at 07:59:40AM +0100, Markus Armbruster wrote: > Back in 2016, we discussed[1] rules for headers, and these were > generally liked: > > 1. Have a carefully curated header that's included everywhere first. We >got that already thanks to Peter: osdep.h. > > 2. Headers shoul

Re: [PATCH v4 00/19] Clean up includes

2023-01-19 Thread Markus Armbruster
Markus Armbruster writes: > Back in 2016, we discussed[1] rules for headers, and these were > generally liked: > > 1. Have a carefully curated header that's included everywhere first. We >got that already thanks to Peter: osdep.h. > > 2. Headers should normally include everything they need b

[PATCH v4 00/19] Clean up includes

2023-01-18 Thread Markus Armbruster
Back in 2016, we discussed[1] rules for headers, and these were generally liked: 1. Have a carefully curated header that's included everywhere first. We got that already thanks to Peter: osdep.h. 2. Headers should normally include everything they need beyond osdep.h. If exceptions are need