Re: [PATCH v4] vfio/common: remove spurious tpm-crb-cmd misalignment warning

2022-05-06 Thread Stefan Berger
On 5/6/22 03:34, Cornelia Huck wrote: On Fri, May 06 2022, Eric Auger wrote: Hi Alex, On 4/28/22 22:14, Alex Williamson wrote: On Thu, 28 Apr 2022 15:49:45 +0200 Eric Auger wrote: +static bool vfio_known_safe_misalignment(MemoryRegionSection *section) +{ +MemoryRegion *mr = sectio

Re: [PATCH v4] vfio/common: remove spurious tpm-crb-cmd misalignment warning

2022-05-06 Thread Cornelia Huck
On Fri, May 06 2022, Eric Auger wrote: > Hi Connie, > > On 5/6/22 09:34, Cornelia Huck wrote: >> On Fri, May 06 2022, Eric Auger wrote: >> >>> Hi Alex, >>> >>> On 4/28/22 22:14, Alex Williamson wrote: On Thu, 28 Apr 2022 15:49:45 +0200 Eric Auger wrote: > +static bool vfio_known_s

Re: [PATCH v4] vfio/common: remove spurious tpm-crb-cmd misalignment warning

2022-05-06 Thread Eric Auger
Hi Connie, On 5/6/22 09:34, Cornelia Huck wrote: > On Fri, May 06 2022, Eric Auger wrote: > >> Hi Alex, >> >> On 4/28/22 22:14, Alex Williamson wrote: >>> On Thu, 28 Apr 2022 15:49:45 +0200 >>> Eric Auger wrote: +static bool vfio_known_safe_misalignment(MemoryRegionSection *section) +{

Re: [PATCH v4] vfio/common: remove spurious tpm-crb-cmd misalignment warning

2022-05-06 Thread Cornelia Huck
On Fri, May 06 2022, Eric Auger wrote: > Hi Alex, > > On 4/28/22 22:14, Alex Williamson wrote: >> On Thu, 28 Apr 2022 15:49:45 +0200 >> Eric Auger wrote: >>> +static bool vfio_known_safe_misalignment(MemoryRegionSection *section) >>> +{ >>> +MemoryRegion *mr = section->mr; >>> + >>> +if

Re: [PATCH v4] vfio/common: remove spurious tpm-crb-cmd misalignment warning

2022-05-06 Thread Eric Auger
Hi Alex, On 4/28/22 22:14, Alex Williamson wrote: > On Thu, 28 Apr 2022 15:49:45 +0200 > Eric Auger wrote: > >> The CRB command buffer currently is a RAM MemoryRegion and given >> its base address alignment, it causes an error report on >> vfio_listener_region_add(). This region could have been a

Re: [PATCH v4] vfio/common: remove spurious tpm-crb-cmd misalignment warning

2022-04-28 Thread Alex Williamson
On Thu, 28 Apr 2022 15:49:45 +0200 Eric Auger wrote: > The CRB command buffer currently is a RAM MemoryRegion and given > its base address alignment, it causes an error report on > vfio_listener_region_add(). This region could have been a RAM device > region, easing the detection of such safe sit

Re: [PATCH v4] vfio/common: remove spurious tpm-crb-cmd misalignment warning

2022-04-28 Thread Cornelia Huck
On Thu, Apr 28 2022, Eric Auger wrote: > The CRB command buffer currently is a RAM MemoryRegion and given > its base address alignment, it causes an error report on > vfio_listener_region_add(). This region could have been a RAM device > region, easing the detection of such safe situation but thi

[PATCH v4] vfio/common: remove spurious tpm-crb-cmd misalignment warning

2022-04-28 Thread Eric Auger
The CRB command buffer currently is a RAM MemoryRegion and given its base address alignment, it causes an error report on vfio_listener_region_add(). This region could have been a RAM device region, easing the detection of such safe situation but this option was not well received. So let's add a he