Re: [PATCH v39 15/22] target/avr: Add example board configuration

2020-01-21 Thread Philippe Mathieu-Daudé
On Wed, Dec 18, 2019 at 10:12 PM Michael Rolnik wrote: > > A simple board setup that configures an AVR CPU to run a given firmware image. > This is all that's useful to implement without peripheral emulation as AVR > CPUs include a lot of on-board peripherals. > > NOTE: this is not a real board !

Re: [PATCH v39 15/22] target/avr: Add example board configuration

2019-12-20 Thread Philippe Mathieu-Daudé
Hi Michael, Few minor comments below. On 12/18/19 10:03 PM, Michael Rolnik wrote: A simple board setup that configures an AVR CPU to run a given firmware image. This is all that's useful to implement without peripheral emulation as AVR CPUs include a lot of on-board peripherals. NOTE: this is

Re: [PATCH v39 15/22] target/avr: Add example board configuration

2019-12-20 Thread Igor Mammedov
On Fri, 20 Dec 2019 14:30:47 +0200 Michael Rolnik wrote: > Hi Igor. > > I don't find where machine->ram is defined. It's not upstream yet (sorry for picking confusing example (there are others with machine->ram_size)). so if you s/memory_region_size(machine->ram)/machine->ram_size/ it will b

Re: [PATCH v39 15/22] target/avr: Add example board configuration

2019-12-20 Thread Michael Rolnik
Hi Igor. I don't find where machine->ram is defined. Regards, Michael Rolnik On Fri, Dec 20, 2019 at 11:51 AM Igor Mammedov wrote: > On Wed, 18 Dec 2019 23:03:22 +0200 > Michael Rolnik wrote: > > > A simple board setup that configures an AVR CPU to run a given firmware > image. > > This is al

Re: [PATCH v39 15/22] target/avr: Add example board configuration

2019-12-20 Thread Igor Mammedov
On Wed, 18 Dec 2019 23:03:22 +0200 Michael Rolnik wrote: > A simple board setup that configures an AVR CPU to run a given firmware image. > This is all that's useful to implement without peripheral emulation as AVR > CPUs include a lot of on-board peripherals. > > NOTE: this is not a real board

[PATCH v39 15/22] target/avr: Add example board configuration

2019-12-18 Thread Michael Rolnik
A simple board setup that configures an AVR CPU to run a given firmware image. This is all that's useful to implement without peripheral emulation as AVR CPUs include a lot of on-board peripherals. NOTE: this is not a real board NOTE: it's used for CPU testing Signed-off-by: Michael Rol