Re: [PATCH v39 03/22] target/avr: Add instruction decoding

2019-12-29 Thread Aleksandar Markovic
On Saturday, December 28, 2019, Michael Rolnik wrote: > Hi Aleksandar. > > This seems less logical to me. > Then next thing will be to partition disassember part right? > > > Please respond inline in future, since inline redponding is standard for this mailing list. What is not logical to you?

Re: [PATCH v39 03/22] target/avr: Add instruction decoding

2019-12-28 Thread Michael Rolnik
Hi Aleksandar. This seems less logical to me. Then next thing will be to partition disassember part right? On Sat, Dec 21, 2019 at 7:15 PM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Saturday, December 21, 2019, Aleksandar Markovic < > aleksandar.m.m...@gmail.com> wrote

Re: [PATCH v39 03/22] target/avr: Add instruction decoding

2019-12-21 Thread Aleksandar Markovic
On Saturday, December 21, 2019, Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Saturday, December 21, 2019, Michael Rolnik wrote: > >> Hi Aleksandar. >> >> please explain. >> >>> >>> > Hi, Michael. > > I wanted to say: > > > 1. Cut the parts of insn.decode that describe coding

Re: [PATCH v39 03/22] target/avr: Add instruction decoding

2019-12-21 Thread Aleksandar Markovic
On Saturday, December 21, 2019, Michael Rolnik wrote: > Hi Aleksandar. > > please explain. > >> >> Hi, Michael. I wanted to say: 1. Cut the parts of insn.decode that describe coding of arithmetic and logic instructions and include them in the patch: target/avr: Add instruction translation - A

Re: [PATCH v39 03/22] target/avr: Add instruction decoding

2019-12-21 Thread Michael Rolnik
Hi Aleksandar. please explain. On Sat, Dec 21, 2019 at 1:18 PM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > > > On Wednesday, December 18, 2019, Michael Rolnik wrote: > >> This includes: >> - encoding of all 16 bit instructions >> - encoding of all 32 bit instructions >> >> Signe

Re: [PATCH v39 03/22] target/avr: Add instruction decoding

2019-12-21 Thread Aleksandar Markovic
On Wednesday, December 18, 2019, Michael Rolnik wrote: > This includes: > - encoding of all 16 bit instructions > - encoding of all 32 bit instructions > > Signed-off-by: Michael Rolnik > Tested-by: Philippe Mathieu-Daudé > --- Michael, I am very pleased that you rearranged the order to be i

[PATCH v39 03/22] target/avr: Add instruction decoding

2019-12-18 Thread Michael Rolnik
This includes: - encoding of all 16 bit instructions - encoding of all 32 bit instructions Signed-off-by: Michael Rolnik Tested-by: Philippe Mathieu-Daudé --- target/avr/insn.decode | 183 + 1 file changed, 183 insertions(+) create mode 100644 target/avr