Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-26 Thread Michael Rolnik
On Wed, Nov 27, 2019 at 1:59 AM Philippe Mathieu-Daudé wrote: > On 11/24/19 6:02 AM, Michael Rolnik wrote: > > Provide function disassembles executed instruction when `-d in_asm` is > > provided > > Maybe "Implement the disassemble_info::print_insn() callback which print > a disassembled instruct

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-26 Thread Philippe Mathieu-Daudé
On 11/24/19 6:02 AM, Michael Rolnik wrote: Provide function disassembles executed instruction when `-d in_asm` is provided Maybe "Implement the disassemble_info::print_insn() callback which print a disassembled instruction." Signed-off-by: Michael Rolnik --- target/avr/cpu.h | 1

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-26 Thread Aleksandar Markovic
On Sunday, November 24, 2019, Michael Rolnik wrote: > Provide function disassembles executed instruction when `-d in_asm` is > provided > > Signed-off-by: Michael Rolnik > --- Michael, hi. It would be very helpful if you include an example in the commit message: - how to start qemu for AVR w

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-26 Thread Aleksandar Markovic
On Tuesday, November 26, 2019, Michael Rolnik wrote: > > > On Tue, Nov 26, 2019 at 9:52 PM Aleksandar Markovic < > aleksandar.m.m...@gmail.com> wrote: > >> On Sun, Nov 24, 2019 at 6:03 AM Michael Rolnik wrote: >> > >> > Provide function disassembles executed instruction when `-d in_asm` is >> >

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-26 Thread Michael Rolnik
On Tue, Nov 26, 2019 at 9:52 PM Aleksandar Markovic < aleksandar.m.m...@gmail.com> wrote: > On Sun, Nov 24, 2019 at 6:03 AM Michael Rolnik wrote: > > > > Provide function disassembles executed instruction when `-d in_asm` is > > provided > > > > Signed-off-by: Michael Rolnik > > --- > > target/

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-26 Thread Aleksandar Markovic
On Sun, Nov 24, 2019 at 6:03 AM Michael Rolnik wrote: > > Provide function disassembles executed instruction when `-d in_asm` is > provided > > Signed-off-by: Michael Rolnik > --- > target/avr/cpu.h | 1 + > target/avr/cpu.c | 2 +- > target/avr/disas.c | 214

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-25 Thread Aleksandar Markovic
On Sunday, November 24, 2019, Michael Rolnik wrote: > Provide function disassembles executed instruction when `-d in_asm` is > provided > > Signed-off-by: Michael Rolnik > --- Richard, is this what you expected from Michael, or there are still some caveats? Thanks for the suggestion! Aleksan

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-24 Thread Aleksandar Markovic
On Sunday, November 24, 2019, Michael Rolnik wrote: > Provide function disassembles executed instruction when `-d in_asm` is > provided > > Signed-off-by: Michael Rolnik > --- You should add "Suggested-by:"s for Philippe, Richard, and myself in tge commit message. Aleksandar target/avr/cpu.

Re: [PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-24 Thread Aleksandar Markovic
On Sunday, November 24, 2019, Michael Rolnik wrote: > Provide function disassembles executed instruction when `-d in_asm` is > provided > > Signed-off-by: Michael Rolnik > --- > target/avr/cpu.h | 1 + > target/avr/cpu.c | 2 +- > target/avr/disas.c | 214 +++

[PATCH v36 10/17] target/avr: Add instruction disassembly function

2019-11-23 Thread Michael Rolnik
Provide function disassembles executed instruction when `-d in_asm` is provided Signed-off-by: Michael Rolnik --- target/avr/cpu.h | 1 + target/avr/cpu.c | 2 +- target/avr/disas.c | 214 + target/avr/translate.c | 11 +++ 4 files cha