Re: [PATCH v3 7/7] hw/xen: Fix errp handling in xen_console

2025-01-15 Thread David Woodhouse
On Wed, 2025-01-15 at 17:49 +0100, Anthony PERARD wrote: > > With those fixed: Reviewed-by: Anthony PERARD Thanks. I've pushed those changes and am watching the pipeline at https://gitlab.com/dwmw2/qemu/-/pipelines/1626804720 I'll probably send a pull request tomorrow. The patch now looks like

Re: [PATCH v3 7/7] hw/xen: Fix errp handling in xen_console

2025-01-15 Thread Anthony PERARD
On Wed, Jan 15, 2025 at 04:27:25PM +, David Woodhouse wrote: > diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c > index e61902461b..9e7f6da343 100644 > --- a/hw/char/xen_console.c > +++ b/hw/char/xen_console.c > @@ -581,19 +581,27 @@ static void > xen_console_device_create(XenBackend

[PATCH v3 7/7] hw/xen: Fix errp handling in xen_console

2025-01-15 Thread David Woodhouse
From: David Woodhouse When attempting to read the 'output' node, interpret any error *other* than ENOENT as a fatal error. For ENOENT, fall back to serial_hd() to find a character device, or create a null device. Do not attempt to prepend to errp when serial_hd() fails; the error isn't relevant