Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

2020-05-27 Thread Philippe Mathieu-Daudé
On 5/27/20 6:49 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 5/26/20 11:31 AM, Philippe Mathieu-Daudé wrote: >>> +Laurent >>> >>> On 5/26/20 11:04 AM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: > On 5/26/20 9:38 AM, Markus Armbruster wrote: >>>

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

2020-05-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 5/26/20 11:31 AM, Philippe Mathieu-Daudé wrote: >> +Laurent >> >> On 5/26/20 11:04 AM, Markus Armbruster wrote: >>> Philippe Mathieu-Daudé writes: >>> On 5/26/20 9:38 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Signed-

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

2020-05-26 Thread Philippe Mathieu-Daudé
On 5/26/20 11:31 AM, Philippe Mathieu-Daudé wrote: > +Laurent > > On 5/26/20 11:04 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 5/26/20 9:38 AM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé A

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

2020-05-26 Thread Philippe Mathieu-Daudé
+Laurent On 5/26/20 11:04 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 5/26/20 9:38 AM, Markus Armbruster wrote: >>> Philippe Mathieu-Daudé writes: >>> Signed-off-by: Philippe Mathieu-Daudé >>> >>> A brief note on why restricting "to machine code" is useful would

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

2020-05-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 5/26/20 9:38 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Signed-off-by: Philippe Mathieu-Daudé >> >> A brief note on why restricting "to machine code" is useful would be >> nice. Same for the other patches. >> >> Acked-by: Markus

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

2020-05-26 Thread Philippe Mathieu-Daudé
On 5/26/20 9:38 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Signed-off-by: Philippe Mathieu-Daudé > > A brief note on why restricting "to machine code" is useful would be > nice. Same for the other patches. > > Acked-by: Markus Armbruster > What about this? "QEMU ca

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

2020-05-26 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé A brief note on why restricting "to machine code" is useful would be nice. Same for the other patches. Acked-by: Markus Armbruster

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

2020-05-26 Thread David Hildenbrand
On 26.05.20 09:35, David Hildenbrand wrote: > On 25.05.20 17:06, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> qapi/machine.json | 90 ++ >> qapi/misc.json | 90 -- >> i

Re: [PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

2020-05-26 Thread David Hildenbrand
On 25.05.20 17:06, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > qapi/machine.json | 90 ++ > qapi/misc.json | 90 -- > include/sysemu/balloon.h | 2 +- > balloon.c

[PATCH v3 4/9] qapi/misc: Restrict balloon-related commands to machine code

2020-05-25 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- qapi/machine.json | 90 ++ qapi/misc.json | 90 -- include/sysemu/balloon.h | 2 +- balloon.c | 2 +- hw/virtio/virtio-balloon.c | 2 +- mon