Re: [PATCH v3 4/7] coroutine: add libucontext as external library

2020-10-29 Thread Stefan Hajnoczi
On Wed, Oct 28, 2020 at 05:59:37PM -0700, Joelle van Dyne wrote: > Mirroring the repo by QEMU is fine and preferred. Not sure if anything > is required from my end there. I can set up the mirror when this patch series is merged. Stefan signature.asc Description: PGP signature

Re: [PATCH v3 4/7] coroutine: add libucontext as external library

2020-10-28 Thread Joelle van Dyne
Mirroring the repo by QEMU is fine and preferred. Not sure if anything is required from my end there. slirp_opt slipped in from a rebase and should not be there, will fix. -j On Wed, Oct 28, 2020 at 4:48 AM Stefan Hajnoczi wrote: > > On Tue, Oct 27, 2020 at 08:06:58PM -0700, Joelle van Dyne wro

Re: [PATCH v3 4/7] coroutine: add libucontext as external library

2020-10-28 Thread Stefan Hajnoczi
On Tue, Oct 27, 2020 at 08:06:58PM -0700, Joelle van Dyne wrote: I am not a lawyer and haven't consulted any lawyers, but libucontext seems compatible with QEMU's license to me. I think QEMU can mirror the libucontext repo and ship it like the other submodules. No changes to QEMU's ./LICENSE are n

[PATCH v3 4/7] coroutine: add libucontext as external library

2020-10-27 Thread Joelle van Dyne
iOS does not support ucontext natively for aarch64 and the sigaltstack is also unsupported (even worse, it fails silently, see: https://openradar.appspot.com/13002712 ) As a workaround we include a library implementation of ucontext and add it as a build option. Signed-off-by: Joelle van Dyne --