Re: [PATCH v3 4/4] x86-disas: add x86-mini disassembler implementation

2025-05-14 Thread Michael Clark
On 5/14/25 21:33, Daniel P. Berrangé wrote: On Wed, May 14, 2025 at 09:23:58PM +1200, Michael Clark wrote: On 5/14/25 20:17, Daniel P. Berrangé wrote: On Wed, May 14, 2025 at 07:39:27PM +1200, Michael Clark wrote: diff --git a/disas/x86-core.c b/disas/x86-core.c new file mode 100644 index

Re: [PATCH v3 4/4] x86-disas: add x86-mini disassembler implementation

2025-05-14 Thread Michael Clark
On 5/14/25 22:25, Philippe Mathieu-Daudé wrote: Hi Michael, Minor comments inline. On 14/5/25 09:39, Michael Clark wrote: [snipped] + +static void x86_print_row(size_t count, x86_table_col *cols) +{ +    printf("|"); +    for (size_t i = 0; i < count; i++) { +    printf(" %-*s |", cols[

Re: [PATCH v3 4/4] x86-disas: add x86-mini disassembler implementation

2025-05-14 Thread Philippe Mathieu-Daudé
Hi Michael, Minor comments inline. On 14/5/25 09:39, Michael Clark wrote: the x86-mini library is a lightweight x86 encoder, decoder, and disassembler that uses extensions to the Intel instruction set metadata to encode modern VEX/EVEX instructions and legacy instructions with a parameterized L

Re: [PATCH v3 4/4] x86-disas: add x86-mini disassembler implementation

2025-05-14 Thread Daniel P . Berrangé
On Wed, May 14, 2025 at 09:23:58PM +1200, Michael Clark wrote: > On 5/14/25 20:17, Daniel P. Berrangé wrote: > > On Wed, May 14, 2025 at 07:39:27PM +1200, Michael Clark wrote: > > > diff --git a/disas/x86-core.c b/disas/x86-core.c > > > new file mode 100644 > > > index ..c4f7034e3420 >

Re: [PATCH v3 4/4] x86-disas: add x86-mini disassembler implementation

2025-05-14 Thread Michael Clark
On 5/14/25 20:17, Daniel P. Berrangé wrote: On Wed, May 14, 2025 at 07:39:27PM +1200, Michael Clark wrote: diff --git a/disas/x86-core.c b/disas/x86-core.c new file mode 100644 index ..c4f7034e3420 --- /dev/null +++ b/disas/x86-core.c @@ -0,0 +1,2716 @@ +/* + * Copyright (c) 2024-202

Re: [PATCH v3 4/4] x86-disas: add x86-mini disassembler implementation

2025-05-14 Thread Daniel P . Berrangé
On Wed, May 14, 2025 at 07:39:27PM +1200, Michael Clark wrote: > the x86-mini library is a lightweight x86 encoder, decoder, and > disassembler that uses extensions to the Intel instruction set > metadata to encode modern VEX/EVEX instructions and legacy > instructions with a parameterized LEX (leg