Re: [PATCH v3 4/4] replication: Remove workaround

2021-07-12 Thread Lukas Straub
On Mon, 12 Jul 2021 13:06:19 +0300 Vladimir Sementsov-Ogievskiy wrote: > 11.07.2021 23:33, Lukas Straub wrote: > > On Fri, 9 Jul 2021 10:49:23 +0300 > > Vladimir Sementsov-Ogievskiy wrote: > > > >> 07.07.2021 21:15, Lukas Straub wrote: > >>> Remove the workaround introduced in commit > >>>

Re: [PATCH v3 4/4] replication: Remove workaround

2021-07-12 Thread Vladimir Sementsov-Ogievskiy
11.07.2021 23:33, Lukas Straub wrote: On Fri, 9 Jul 2021 10:49:23 +0300 Vladimir Sementsov-Ogievskiy wrote: 07.07.2021 21:15, Lukas Straub wrote: Remove the workaround introduced in commit 6ecbc6c52672db5c13805735ca02784879ce8285 "replication: Avoid blk_make_empty() on read-only child". It i

Re: [PATCH v3 4/4] replication: Remove workaround

2021-07-11 Thread Lukas Straub
On Fri, 9 Jul 2021 10:49:23 +0300 Vladimir Sementsov-Ogievskiy wrote: > 07.07.2021 21:15, Lukas Straub wrote: > > Remove the workaround introduced in commit > > 6ecbc6c52672db5c13805735ca02784879ce8285 > > "replication: Avoid blk_make_empty() on read-only child". > > > > It is not needed anymore

Re: [PATCH v3 4/4] replication: Remove workaround

2021-07-09 Thread Vladimir Sementsov-Ogievskiy
07.07.2021 21:15, Lukas Straub wrote: Remove the workaround introduced in commit 6ecbc6c52672db5c13805735ca02784879ce8285 "replication: Avoid blk_make_empty() on read-only child". It is not needed anymore since s->hidden_disk is guaranteed to be writable when secondary_do_checkpoint() runs. Beca

[PATCH v3 4/4] replication: Remove workaround

2021-07-07 Thread Lukas Straub
Remove the workaround introduced in commit 6ecbc6c52672db5c13805735ca02784879ce8285 "replication: Avoid blk_make_empty() on read-only child". It is not needed anymore since s->hidden_disk is guaranteed to be writable when secondary_do_checkpoint() runs. Because replication_start(), _do_checkpoint(