Re: [PATCH v3 3/9] vfio: add quirk device write method

2020-07-17 Thread Alex Williamson
On Fri, 17 Jul 2020 16:57:40 +0100 Peter Maydell wrote: > On Fri, 17 Jul 2020 at 16:54, Alex Williamson > wrote: > > > > On Thu, 16 Jul 2020 18:46:33 +0100 > > Peter Maydell wrote: > > > > > Alex (Williamson) -- as the vfio maintainer, do you have a view > > > on whether we should be logging

Re: [PATCH v3 3/9] vfio: add quirk device write method

2020-07-17 Thread Peter Maydell
On Fri, 17 Jul 2020 at 16:54, Alex Williamson wrote: > > On Thu, 16 Jul 2020 18:46:33 +0100 > Peter Maydell wrote: > > > Alex (Williamson) -- as the vfio maintainer, do you have a view > > on whether we should be logging write accesses to port 0x3c3 > > here as guest-errors or unimplemented-QEMU-

Re: [PATCH v3 3/9] vfio: add quirk device write method

2020-07-17 Thread Alex Williamson
On Thu, 16 Jul 2020 18:46:33 +0100 Peter Maydell wrote: > On Tue, 30 Jun 2020 at 13:30, P J P wrote: > > > > From: Prasad J Pandit > > > > Add vfio quirk device mmio write method to avoid NULL pointer > > dereference issue. > > > > Reported-by: Lei Sun > > Reviewed-by: Li Qiang > > Signed-off

Re: [PATCH v3 3/9] vfio: add quirk device write method

2020-07-16 Thread Peter Maydell
On Tue, 30 Jun 2020 at 13:30, P J P wrote: > > From: Prasad J Pandit > > Add vfio quirk device mmio write method to avoid NULL pointer > dereference issue. > > Reported-by: Lei Sun > Reviewed-by: Li Qiang > Signed-off-by: Prasad J Pandit > --- > hw/vfio/pci-quirks.c | 8 > 1 file cha

[PATCH v3 3/9] vfio: add quirk device write method

2020-06-30 Thread P J P
From: Prasad J Pandit Add vfio quirk device mmio write method to avoid NULL pointer dereference issue. Reported-by: Lei Sun Reviewed-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/vfio/pci-quirks.c | 8 1 file changed, 8 insertions(+) Update v3: Add Reviewed-by: ... -> https: