Re: [PATCH v3 3/7] qapi/expr: Split check_expr out from check_exprs

2023-02-14 Thread John Snow
On Sat, Feb 11, 2023, 5:06 AM Markus Armbruster wrote: > John Snow writes: > > > --3b01fe05f45a096a > > Content-Type: text/plain; charset="UTF-8" > > > > On Fri, Feb 10, 2023, 7:33 AM Markus Armbruster > wrote: > > > >> Another observation... > >> > >> John Snow writes: > >> > >> >

Re: [PATCH v3 3/7] qapi/expr: Split check_expr out from check_exprs

2023-02-11 Thread Markus Armbruster
John Snow writes: > --3b01fe05f45a096a > Content-Type: text/plain; charset="UTF-8" > > On Fri, Feb 10, 2023, 7:33 AM Markus Armbruster wrote: > >> Another observation... >> >> John Snow writes: >> >> > Primarily, this reduces a nesting level of a particularly long >> > block. It's m

Re: [PATCH v3 3/7] qapi/expr: Split check_expr out from check_exprs

2023-02-10 Thread John Snow
On Fri, Feb 10, 2023, 7:33 AM Markus Armbruster wrote: > Another observation... > > John Snow writes: > > > Primarily, this reduces a nesting level of a particularly long > > block. It's mostly code movement, but a new docstring is created. > > > > It also has the effect of creating a fairly con

Re: [PATCH v3 3/7] qapi/expr: Split check_expr out from check_exprs

2023-02-10 Thread Markus Armbruster
Another observation... John Snow writes: > Primarily, this reduces a nesting level of a particularly long > block. It's mostly code movement, but a new docstring is created. > > It also has the effect of creating a fairly convenient "catch point" in > check_exprs for exception handling without m

Re: [PATCH v3 3/7] qapi/expr: Split check_expr out from check_exprs

2023-02-10 Thread Markus Armbruster
John Snow writes: > Primarily, this reduces a nesting level of a particularly long > block. It's mostly code movement, but a new docstring is created. > > It also has the effect of creating a fairly convenient "catch point" in > check_exprs for exception handling without making the nesting level

[PATCH v3 3/7] qapi/expr: Split check_expr out from check_exprs

2023-02-09 Thread John Snow
Primarily, this reduces a nesting level of a particularly long block. It's mostly code movement, but a new docstring is created. It also has the effect of creating a fairly convenient "catch point" in check_exprs for exception handling without making the nesting level even worse. Signed-off-by: J