Re: [PATCH v3 3/6] net/colo-compare.c: Fix deadlock in compare_chr_send

2020-04-29 Thread Lukas Straub
> > From: Lukas Straub > > > > Sent: Monday, April 27, 2020 5:19 AM > > > > To: qemu-devel > > > > Cc: Zhang, Chen ; Li Zhijian > > > > ; Jason Wang ; Marc- > > > > André Lureau ; Paolo Bonzini > > > >

RE: [PATCH v3 3/6] net/colo-compare.c: Fix deadlock in compare_chr_send

2020-04-28 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Monday, April 27, 2020 3:22 PM > To: Zhang, Chen > Cc: qemu-devel ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: Re: [PATCH v3 3/6] net/colo-compare.c: Fix deadlock in > co

Re: [PATCH v3 3/6] net/colo-compare.c: Fix deadlock in compare_chr_send

2020-04-27 Thread Lukas Straub
reau ; Paolo Bonzini > > > > Subject: [PATCH v3 3/6] net/colo-compare.c: Fix deadlock in > > compare_chr_send > > > > The chr_out chardev is connected to a filter-redirector running in the main > > loop. qemu_chr_fe_write_all might block here in compare_chr_se

RE: [PATCH v3 3/6] net/colo-compare.c: Fix deadlock in compare_chr_send

2020-04-26 Thread Zhang, Chen
> -Original Message- > From: Lukas Straub > Sent: Monday, April 27, 2020 5:19 AM > To: qemu-devel > Cc: Zhang, Chen ; Li Zhijian > ; Jason Wang ; Marc- > André Lureau ; Paolo Bonzini > > Subject: [PATCH v3 3/6] net/colo-compare.c: Fix deadlock in > com

[PATCH v3 3/6] net/colo-compare.c: Fix deadlock in compare_chr_send

2020-04-26 Thread Lukas Straub
The chr_out chardev is connected to a filter-redirector running in the main loop. qemu_chr_fe_write_all might block here in compare_chr_send if the (socket-)buffer is full. If another filter-redirector in the main loop want's to send data to chr_pri_in it might also block if the buffer is full. Thi